[Bug 14190] New: Scale search boxes in staff head
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Bug ID: 14190 Summary: Scale search boxes in staff head Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org I've had pointed out to me that the search boxes in the head of the staff interface in unnecessarily small. For catalog search it could even shape the expectation of how many search terms is expected and unconsciously steer librarians towards broader searches. Since screens is often bigger these days and the area right of the search box is unused it seems a bit conservative to go with "size 40". I suggest that we make the container float up to some max size and then let the individual search boxes be for example size 60 but also have the CSS rule of "width:100%" to resize with the container. That way it will use the space better, scale up and down and still not become ridiculously huge on a 27". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14189 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren@yahoo.no --- Comment #1 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Changes here may cause a merge conflict with the signed off 14189 since some of the same files must be updated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #2 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Owen - we'll gladly let you write this patch. But give us a shout if not since Eivin is ready to write it otherwise. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #3 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Got an update from Cait that template bugs are auto assigned to Owen so we're going for this one ourselves :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |eskaaren@yahoo.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #4 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 43572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43572&action=edit Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43572|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 43574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43574&action=edit Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43574|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43945&action=edit [PASSED QA] Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is really a question of taste somehow. I am passing this, as it can be easily changed back with a line in IntranetUserCSS and we can see how people like it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Eivin and congratulations for your commit! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org