http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20378&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20378|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 20384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20384&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." The triggered form is now labelled "Number of additional copies of this item to add" in an attempt to convey the fact that the number entered will be added to the one item represented by the item form above. i.e. if you enter "3" as the number of additional copies, you will end up with 4. Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Liz Rea <liz@catalyst.net.nz> All cases tested. I like this change, much clearer. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20394&action=edit Bug 10347: Scroll down clicking on the "Add multiple copies" button -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- That's not how it has worked for me in the past - it has only added the number in the box ... so that might be a bug. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20384|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25463&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #10 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- I tested this patch and have two remarks : - If the barcode entered in the item to duplicate is already used in db it is incremented and so are the multiple items duplicated (no duplicate warning); - why is barcode created if system preference 'autobarcode' is turned to off ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to jmbroust from comment #10)

- If the barcode entered in the item to duplicate is already used in db it is incremented and so are the multiple items duplicated (no duplicate warning); - why is barcode created if system preference 'autobarcode' is turned to off ?

Are these regressions caused by this patch or could they be put into separate bugs? -- You are receiving this mail because: You are watching all bug changes.