https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- https://github.com/Koha-Community/Koha/blob/5832521086b06c2221474791278ebd9b... We should use patron-title.inc here instead of grabbing firstname and surname directly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185745&action=edit Bug 40699: Use patron-title for course reserve instructor To test: 1 - have or make a course reserves course with an instructor 2 - give your instructor a preferred name, confirm the course shows their firstname instead 3 - apply patch, reload page 4 - confirm course now shows their preferred_name instead 5 - edit the patron to remove the preferred name, confirm course shows first name again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Raina <raina@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raina@flo.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Noah <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185745|0 |1 is obsolete| | --- Comment #3 from Noah <noah.tremblay@inlibro.com> --- Created attachment 186233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186233&action=edit Bug 40699: Use patron-title for course reserve instructor To test: 1 - have or make a course reserves course with an instructor 2 - give your instructor a preferred name, confirm the course shows their firstname instead 3 - apply patch, reload page 4 - confirm course now shows their preferred_name instead 5 - edit the patron to remove the preferred name, confirm course shows first name again Signed-off-by: noah <noah@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Andrew, I found other places: * Create/edit a course * Course list Can you test and confirm it is needed as well please? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Note that I found several other places where they are not displayed correctly. I have fixed them on bug 32176. Please have a look :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)

Andrew, I found other places: * Create/edit a course * Course list

Can you test and confirm it is needed as well please? :)

Those places both look good! They reminded me to go look at the OPAC, where we show firstname rather then preferred_name in both the course list and the course details. I'll aim to get back there and add those, but if you beat me to it and assign the bug to yourself, I'll be happy to sign off on it. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)

I would suggest to do that on a separate bug report

Fair enough! setting this back to NSO -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32176 |40958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32176 [Bug 32176] Correctly display patrons when selected after autocomplete (was js/patron-autocomplete.js need another option) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 [Bug 40958] Move patron_to_html (from js-patron-format.inc) to a standalone JS file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188799&action=edit Bug 40699: Correctly format patron everywhere in course reserves Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.