[Bug 39280] New: Generalize notice text: If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Bug ID: 39280 Summary: Generalize notice text: If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned. Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The notice makes an assumption about the configuration that might not always be true: If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned. installer/data/mysql/en/mandatory/sample_notices.yml:letter:1:row:32:mul:15 It would be better to rephrase to make it more general. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Notice code: ODUE I would suggest we just remove this line. The notice already requests the user to return or renew ASAP, which probably does enough for a template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 --- Comment #2 from sasha.anastasi+bugzilla@catalyst.net.nz --- Created attachment 184245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184245&action=edit Bug 39280: remove misleading message text Test plan: 1. refresh database 2. verify ODUE notice text does not include the line "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 sasha.anastasi+bugzilla@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |sasha.anastasi+bugzilla@cat |ity.org |alyst.net.nz Status|NEW |Needs Signoff CC| |sasha.anastasi+bugzilla@cat | |alyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184245|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 184250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184250&action=edit Bug 39280: remove misleading message text Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |unnecessary or misleading | |text from the ODUE notice, | |as it depends on the | |library's settings: "If an | |item becomes more than 30 | |days overdue, you will be | |unable to use your library | |card until the item is | |returned.". | | | |Note: The notice is not | |automatically updated for | |existing installations. | |Update the notice manually | |to remove this wording if | |required, or replace the | |default notice using "View | |default" and "Copy to | |template" if you have not | |customized the notice. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Sasha. Nice work! I've signed off, as it does what it says in the test plan. For some reason, the test plan is not included in the signed off commit message when I attached it, so you will need to amend the commit message. I would suggest rewording the commit message to help it pass QA, following the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages Suggested wording: --- Bug 39280: Remove misleading message text for ODUE notice This patch removes unnecessary and misleading wording from the overdue note as it depends on the library's circulation rules: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." Test plan: 1. Check the wording of the ODUE notice under Tools > Patrons and circulation > Notices and slips. 2. Note that it includes this wording, which may be unnecessary or misleading depending on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." 3. Apply the patch. 4. Check that the updated ODUE notice has removed the wording by either: 4.1 Resetting everything: reset_all 4.2 Viewing the default notice - click "View default" when viewing the email notice 5. Sign off. --- I've also added a release note. David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Generalize notice text: If |Generalize ODUE notice text |an item becomes more than |- remove "If an item |30 days overdue, you will |becomes more than 30 days |be unable to use your |overdue, you will be unable |library card until the item |to use your library card |is returned. |until the item is | |returned." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement removes |This enhancement removes release notes|unnecessary or misleading |unnecessary or misleading |text from the ODUE notice, |text from the ODUE notice, |as it depends on the |as it depends on the |library's settings: "If an |library's settings: "If an |item becomes more than 30 |item becomes more than 30 |days overdue, you will be |days overdue, you will be |unable to use your library |unable to use your library |card until the item is |card until the item is |returned.". |returned.". | | |Note: The notice is not |Note: The notice is not |automatically updated for |automatically updated for |existing installations. |existing installations. |Update the notice manually |Update the notice manually |to remove this wording if |to change the wording if |required, or replace the |required, or replace the |default notice using "View |default notice using "View |default" and "Copy to |default" and "Copy to |template" if you have not |template" if you have not |customized the notice. |customized the notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39279 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184250|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 184420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184420&action=edit Bug 39280: Remove misleading message text for ODUE notice This patch removes unnecessary and misleading wording from the overdue note as it depends on the library's circulation rules: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." Test plan: 1. Check the wording of the ODUE notice under Tools > Patrons and circulation > Notices and slips. 2. Note that it includes this wording, which may be unnecessary or misleading depending on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." 3. Apply the patch. 4. Check that the updated ODUE notice has removed the wording by either: 4.1 Resetting everything: reset_all 4.2 Viewing the default notice - click "View default" when viewing the email notice 5. Sign off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #4)
Hi Sasha.
Nice work!
I've signed off, as it does what it says in the test plan.
For some reason, the test plan is not included in the signed off commit message when I attached it, so you will need to amend the commit message.
Thanks so much David, I have done this on Sasha's behalf! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Aleisha Amohia from comment #6)
(In reply to David Nind from comment #4)
Hi Sasha.
Nice work!
I've signed off, as it does what it says in the test plan.
For some reason, the test plan is not included in the signed off commit message when I attached it, so you will need to amend the commit message.
Thanks so much David, I have done this on Sasha's behalf!
Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184420|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189081&action=edit Bug 39280: Remove misleading message text for ODUE notice This patch removes unnecessary and misleading wording from the overdue note as it depends on the library's circulation rules: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." Test plan: 1. Check the wording of the ODUE notice under Tools > Patrons and circulation > Notices and slips. 2. Note that it includes this wording, which may be unnecessary or misleading depending on the library's settings: "If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned." 3. Apply the patch. 4. Check that the updated ODUE notice has removed the wording by either: 4.1 Resetting everything: reset_all 4.2 Viewing the default notice - click "View default" when viewing the email notice 5. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39280 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org