[Bug 39276] New: OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Bug ID: 39276 Summary: OPACShowHoldQueueDetails datatable warning Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Place an item on hold. 3. Log in to your OPAC and go to your Holds history tab. 4. Click on your hold that is marked as "Pending". 5. Notice that a datatable warning appears similar to: "DataTables warning: table id=holdingst - Requested unknown parameter '6' for row 0, column 6. For more information about this error, please see https://datatables.net/tn/4" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This is in main? I'm not seeing an error with any setting of OPACShowHoldQueueDetails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #1)
This is in main? I'm not seeing an error with any setting of OPACShowHoldQueueDetails.
Whoops never mind, I see it now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com --- Comment #3 from David Kuhn <techservspec@gmail.com> --- This error seems to occur on "Next available" holds where there are no item specific holds on the first item shown in the holdings list for the title. Perhaps it's related to the "item hold queue priority" being blank on the first item? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There seems to be no reason to show the column at all if there are no item level holds. You shouldn't be able to mix item level and record level holds. Then we don't need to pass show_priority to the template either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #4)
There seems to be no reason to show the column at all if there are no item level holds. You shouldn't be able to mix item level and record level holds.
Then we don't need to pass show_priority to the template either.
Nevermind, we pass priority when the hold is not item level: 623 $hold->itemnumber 624 ? ( $priority{ $hold->itemnumber } = $hold->priority ) 625 : ( $template->param( priority => $hold->priority ) ); We just need to show it in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180996&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180996|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 181206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181206&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes: 1. Step 1 - Enable the holds history system preference: OPACHoldsHistory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181206|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182181&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't understand this patch. Here is the diff: + [% ELSIF show_priority %] + <td class="holds_priority">[% priority | html %] </td> [% END %] Here is the context: [% IF item_level_holds > 0 || show_priority %] <td class="holds_count"> [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] [% IF ITEM_RESULT.priority %] [% IF holds_count.defined %] <span>(priority [% ITEM_RESULT.priority | html %])</span> [% ELSE %] <span>[% ITEM_RESULT.priority | html %]</span> [% END %] [% END %] </td> [% ELSIF show_priority %] <td class="holds_priority">[% priority | html %] </td> [% END %] we never reach the ELSIF, we have || show_priority in the first condition. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 [Bug 41010] Incorrect show_priority condition in opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #12)
I don't understand this patch.
Here is the diff: + [% ELSIF show_priority %] + <td class="holds_priority">[% priority | html %] </td> [% END %]
Here is the context: [% IF item_level_holds > 0 || show_priority %] <td class="holds_count"> [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] [% IF ITEM_RESULT.priority %] [% IF holds_count.defined %] <span>(priority [% ITEM_RESULT.priority | html %])</span> [% ELSE %] <span>[% ITEM_RESULT.priority | html %]</span> [% END %] [% END %] </td> [% ELSIF show_priority %] <td class="holds_priority">[% priority | html %] </td> [% END %]
we never reach the ELSIF, we have || show_priority in the first condition.
I have opened bug 41010. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #15 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org