[Bug 41010] New: Incorrect show_priority condition in opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Bug ID: 41010 Summary: Incorrect show_priority condition in opac-detail Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 39276
From bug 39276 comment 12
I don't understand this patch. Here is the diff: + [% ELSIF show_priority %] + <td class="holds_priority">[% priority | html %] </td> [% END %] Here is the context: [% IF item_level_holds > 0 || show_priority %] <td class="holds_count"> [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] [% IF ITEM_RESULT.priority %] [% IF holds_count.defined %] <span>(priority [% ITEM_RESULT.priority | html %])</span> [% ELSE %] <span>[% ITEM_RESULT.priority | html %]</span> [% END %] [% END %] </td> [% ELSIF show_priority %] <td class="holds_priority">[% priority | html %] </td> [% END %] we never reach the ELSIF, we have || show_priority in the first condition. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 [Bug 39276] OPACShowHoldQueueDetails datatable warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187855&action=edit Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39452 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug 39276 clashed with bug 39452. The changes from bug 39452 was totally unrelated to the rest of the patch - [% IF item_level_holds > 0 %] + [% IF item_level_holds > 0 || show_priority %] Lucas and Nick, please clarify. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 [Bug 39452] Log cardnumber changes as distinct action within borrower logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187855|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188027&action=edit Bug 41010: Adjust show_priority condition in opac-detail We had [% IF item_level_holds > 0 || show_priority %] [% ELSIF show_priority %] We never reach ELSIF. I am not sure what's the correct fix here. People involved on bug 39276 should help. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
Bug 39276 clashed with bug 39452.
The changes from bug 39452 was totally unrelated to the rest of the patch
- [% IF item_level_holds > 0 %] + [% IF item_level_holds > 0 || show_priority %]
Lucas and Nick, please clarify.
If I had to guess, I was writing 39452 - then tried to help with 39276, and accidentally included an unrelated line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 39452 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Bug 41010 depends on bug 39452, which changed state. Bug 39452 Summary: Log cardnumber changes as distinct action within borrower logs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 Bug 41010 depends on bug 39276, which changed state. Bug 39276 Summary: OPACShowHoldQueueDetails datatable warning https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org