[Bug 23349] New: Merge records from a search result (catalog/search.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Bug ID: 23349 Summary: Merge records from a search result (catalog/search.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@collecto.ca QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Hi, It would be interesting to be able to merge records from a list of results (catalogue/search.pl). The search results in cataloguing/addbooks.pl, where you can merge records, does not filter by document type or other status. Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED Summary|Merge records from a search |Add batch operations to |result (catalog/search.pl) |staff interface catalog | |search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 102468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102468&action=edit Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #2 from Abbey Holt <aholt@dubuque.lib.ia.us> --- After checking one box and selecting "Batch delete" the following message appears: "You must select at least one record." The rest of the testing was successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim@devinim.com.tr --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- Hi Owen, We applied the patch and saw the Edit button but when we checked one of the search, edit button was still disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102468|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 102620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102620&action=edit Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Abbey Holt from comment #2)
After checking one box and selecting "Batch delete" the following message appears: "You must select at least one record."
This should now be fixed. (In reply to Devinim from comment #3)
We applied the patch and saw the Edit button but when we checked one of the search, edit button was still disabled.
I could not reproduce this problem. Could you clear your browser cache and try the new patch? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102620|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 102621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102621&action=edit Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Changing status to "Signed off" based on comment 6. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, please check the strings in the js file - they are not showing up for me in the *messages-js.po file! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103171&action=edit Bug 23349: (follow-up) Correct translation function This patch corrects the translation function inside results.js. It should be two underscores instead of one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102621|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103190&action=edit Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103171|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103191&action=edit Bug 23349: (follow-up) Correct translation function This patch corrects the translation function inside results.js. It should be two underscores instead of one. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One of Owen's magical patches :) I only have one little concern/thing I am not sure about, maybe to have a second look at later: If you check the checkboxes, choose one of the batch features and then use "back" in the browser (maybe you have chosen the wrong one), the checkboxes are still checked, but the "Edit" pull down is disabled. You have to uncheck/check something for it to unlock again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another little thing: We have the browse feature now that can carry checkboxes over multiple pages - having the edit do this as well would be pretty awesome. This will still ease people's pain a lot, especially when merging records. It's always a bit hard to explain in training that you have to use the more limited cataloguing search for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Wit this enhancement there release notes| |is a new "Edit" menu on the | |catalog search that allows | |to "Batch edit", "Batch | |delete" and "Merge" | |selected records from the | |result list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Wit this enhancement there |With this enhancement there release notes|is a new "Edit" menu on the |is a new "Edit" menu on the |catalog search that allows |catalog search that allows |to "Batch edit", "Batch |to "Batch edit", "Batch |delete" and "Merge" |delete," and "Merge" |selected records from the |selected records from the |result list. |result list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 [Bug 25659] Hide batch actions from reports results if no permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26859 [Bug 26859] Options to Batch Edit Batch Delete and Batch Merge are Sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30720 [Bug 30720] Batch delete links from result list missing permission checks -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org