[Bug 30701] New: On small screens, upload tool buttons cannot be clicked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Bug ID: 30701 Summary: On small screens, upload tool buttons cannot be clicked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The Upload tool can be accessed for Tools, and as a cataloguing plugin. This was noticed when used for the plugin because it opened on a smaller window. When the window is made smaller than 768 pixels, the 'Browse' and 'Upload' buttons in the 'Upload new file' section cannot be clicked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 134670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134670&action=edit Bug 30701: Make Upload Tool buttons work on mobile-size screen When the Upload tool is accessed on a smaller (mobile) screen (less than 768 pixels wide), the Upload and Browse buttons cannot be clicked. This patch fixes that. To test: 1) Go to Tools -> Upload 2) Make the screen narrower, either by opening your browser's Inspector tool and using Responsive Design Mode, or by dragging in the edge of the window to make it narrower. 3) Notice that when the screen becomes narrower than 768px, the sections squash together and the padding between them is lost. Try to click on the Browse and Upload buttons, notice you cannot. 4) Apply patch and refresh the Upload Tool 5) Ensure the screen is narrower than 768px. Confirm there is now padding between the sections, and the buttons are clickable again. Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Could you attach a screenshot of how it looks before the patch? I'm not sure I'm seeing what you're seeing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134670|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 134762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134762&action=edit Bug 30701: Make Upload Tool buttons work on mobile-size screen When the Upload tool is accessed on a smaller (mobile) screen (less than 768 pixels wide), the Upload and Browse buttons cannot be clicked. This patch fixes that. To test: 1) Go to Tools -> Upload 2) Make the screen narrower, either by opening your browser's Inspector tool and using Responsive Design Mode, or by dragging in the edge of the window to make it narrower. 3) Notice that when the screen becomes narrower than 768px, the sections squash together and the padding between them is lost. Try to click on the Browse and Upload buttons, notice you cannot. 4) Apply patch and refresh the Upload Tool 5) Ensure the screen is narrower than 768px. Confirm there is now padding between the sections, and the buttons are clickable again. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 134769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134769&action=edit Screenshot of upload tool to display Step 3 of the test plan (In reply to Owen Leonard from comment #2)
Could you attach a screenshot of how it looks before the patch? I'm not sure I'm seeing what you're seeing.
Screenshot attached. This describes Step 3 of the test plan. As you can see I've made the page smaller than 768px and the padding between the two sections is gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134762|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134975&action=edit Bug 30701: Make Upload Tool buttons work on mobile-size screen When the Upload tool is accessed on a smaller (mobile) screen (less than 768 pixels wide), the Upload and Browse buttons cannot be clicked. This patch fixes that. To test: 1) Go to Tools -> Upload 2) Make the screen narrower, either by opening your browser's Inspector tool and using Responsive Design Mode, or by dragging in the edge of the window to make it narrower. 3) Notice that when the screen becomes narrower than 768px, the sections squash together and the padding between them is lost. Try to click on the Browse and Upload buttons, notice you cannot. 4) Apply patch and refresh the Upload Tool 5) Ensure the screen is narrower than 768px. Confirm there is now padding between the sections, and the buttons are clickable again. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30701 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org