[Bug 26847] New: Make borrower category code accessible in all pages of the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Bug ID: 26847 Summary: Make borrower category code accessible in all pages of the OPAC Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: rickard.lindfors@sh.se QA Contact: testopia@bugs.koha-community.org It would be useful to see which borrower category a user has when logged in. This way, the library could personalize information with javascript, to certain categories. On every page, there's for example: data-borrowernumber and data-branchcode. Maybe here, it would be suitable for a data-borrowercategory? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113003&action=edit Bug 26847: Add unit test for categorycode in masthead This unit test adds a regression test for the addition of categorycode into the masthead of the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113004&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113003|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 113012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113012&action=edit Bug 26847: Add unit test for categorycode in masthead This unit test adds a regression test for the addition of categorycode into the masthead of the staff client. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113004|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 113013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113013&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114726&action=edit Bug 26847: Add UI test for categorycode in masthead This test adds a regression test for the addition of categorycode into the masthead of the staff client. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113013|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114727&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | Status|Signed Off |Passed QA CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113012|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 113012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113012 Bug 26847: Add unit test for categorycode in masthead Fixed test terminology in the commit message "unit test" => "UI test" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Another idea is to provide a Javascript object that is accessible by Javascript. That could be a more extensible way of getting this functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #8)
Another idea is to provide a Javascript object that is accessible by Javascript.
That could be a more extensible way of getting this functionality.
But it would make it harder to tie CSS to it. I think having it in the HTML works well for both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |unspecified CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #9)
(In reply to David Cook from comment #8)
Another idea is to provide a Javascript object that is accessible by Javascript.
That could be a more extensible way of getting this functionality.
But it would make it harder to tie CSS to it. I think having it in the HTML works well for both.
Looking at the previous comments, no one mentioned CSS; they only mentioned Javascript. But I think that you make a really good point. It could be interesting to use CSS tied to borrower category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114872&action=edit Bug 26847: (follow-up) fix get_attribute() call Since the upgrade to Selenium 3 in bug 27055, an additional parameter is required for get_attribute() to actually work. https://metacpan.org/pod/Selenium::Remote::WebElement#get_attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small yet useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05. Please ask if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #16 from Rickard Lindfors <rickard.lindfors@sh.se> --- Yes, please backport to 20.05 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #17 from Rickard Lindfors <rickard.lindfors@sh.se> --- Hi Andrew! Can you please backport to 20.05? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Victor, can you have a look at backporting these patches into 20.05 please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.16 released in| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #20 from Rickard Lindfors <rickard.lindfors@sh.se> --- Thanks Victor! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #21 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.22? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- the request was only for 20.05.x severity is not >= to major so you don't have to try to backport But it's your call to try to backport some things anyway if they are low risk. I tend to do that for accessibility and translatability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #23 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org