https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15278 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #3 from Rebecca Coert <rcoert@arlingtonva.us> --- +1 We need this! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #5 from Jason Robb <jrobb@sekls.org> --- +1 yes, please! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #6 from Kristi <kkrueger@cuyahogalibrary.org> --- Agreed that TT documentation tailored for Koha users is needed. A glossary of fields from Koha that can be included in notices and how data from those fields can be formatted would be helpful as part of the documentation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Some thoughts / useful information I've come across while digging into the code to figure out what bug 15278 will entail: (This is mostly answering the questions of "what information do we need to provide to users?" and "where can we find this information in the code if it isn't well documented?") - To get a list of what TT objects are available to notices in general, possible places to look are two subs in C4::Letters: _get_tt_params and _parseletter_sth. ~ Near the beginning of _get_tt_params, a $config variable is defined that maps database table names to Template Toolkit variable names. ~ _parseletter_sth actually prepares (and caches?) database queries for notices ~ These two subs aren't 100% in sync with each other, though (I haven't dug quite deep enough to be sure if that's a bug in and of itself) - To know which specific tables a specific notice has access to, I believe one way to do that would be to find the GetPreparedLetter call for that notice. A list of tables is passed as a parameter. (git grep is your friend here) - Due, Predue, and Overdue notices might be weird - they have some custom handling in advance_notices.pl and overdue_notices.pl. There are also a few other notices that have weird custom things that aren't handled yet in Template Toolkit syntax. (See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278#c11) - Some Koha-specific TT things that aren't tied to a particular table that we should include: ~ accessing today's date ~ formatting a date ~ I feel like I've seen some environment context / syspref configuration things getting used in notices before? - We should include an explanation of how a TT variable can be singular or plural, and when and how to use each. (Is there any situation where we'd use the plural, other than a FOREACH loop or a count?) - We definitely need to make sure the '----' syntax for digest notices is documented, and probably include an explanation of when to use '----' and when to use a FOREACH. - I believe any database field in a given table is accessible as a variable in notices that have access to that table? If I'm correct in that, it would be really useful for the Template Toolkit documentation to link to the schema page for the relevant tables. - Ideally, it would be a nice idea to include some very basic, layman-friendly TT info as a starting point for users who may not have a programming background or experience reading technical documentation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- If I understand correctly, this https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables... is too vague? It's the one I use most often to know what is available in which notice. I also made a list of variables to copy-paste for my clients (in French, but the variables are in English, so it should be pretty easy to understand) https://inlibro.com/knowledge-base/definition-des-champs-pour-les-lettres-et... It might be obvious to English speakers that borrower.firstname is the borrower's first name, but if you don't speak English, it's a bit harder to figure out :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #10)

(In reply to Caroline Cyr La Rose from comment #9)

...

If I understand correctly, this https://wiki.koha-community.org/wiki/ Notices_with_Template_Toolkit#Variables_available_in_each_notice is too vague? It's the one I use most often to know what is available in which notice.

This is helpful. I'm not seeing newer templates (like for reports). Do you have that information?

Also, this lists availability by notice code, which seems a bit arbitrary. Would this be a more efficient list by listing what is available to each module, rather than specific notice?

I believe it is in part actually different between notices, not tied to modules. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #12)

Hmmm....that makes no sense to me. So if I were to create a new Overdue Notice with a completely different code, I wouldn't be able to use the template toolkit objects associate with it because I didn't use a specific code?

It works for overdue, but it's not the code or the module, but because you configure it in the notice triggers. The system knows it's an overdue and pulls the data accordingly.

This seems ripe with potential issues down the road. It seems like the TT objects should be associate with the module, not a code. Otherwise, that would be a nightmare for custom notices down the road. Does that make any sense, or am I just out of my mind?

I'd say they are more tied to the function that generates the notice/slip. Some features allow you to configure the code to use like overdues, some are tied to a specific code and some to a specific module. I expect us to not be overall consistent right now as the code doesn't use the module to determine the objects available in general. For an examples: Bug 29100 - Add checkouts data loop to predue/due notices script (advance_notices.pl) Changed the advance_notices script to make the checkouts object available to TT, but only for the notices sent by this script, not for all in circulation module. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanel.wheeler@yavapaiaz.go | |v --- Comment #14 from Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> --- +1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david@davidnind.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #17)

https://bywatersolutions791.zohodesk.com/portal/en/kb/articles/data- availability-via-template-toolkit-per-notice-slip

I pulled some notes and examples together here that may be helpful to folks waiting on this documentation.

I may have missed it in your examples, but it would be helpful to understand dumper. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Tom Rice <tom.rice@cityofcarrollton.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tom.rice@cityofcarrollton.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #20)

Hi Andrew, the link no longer works or is not accessible - could you please check? Thank you!

New URL, apologies for the interruption :) https://help.bywatersolutions.com/portal/en/kb/articles/data-availability-vi... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Danielle M. <dmeininger591@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmeininger591@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.