[Bug 15253] New: Add Koha::Logger based logging for SIP2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Bug ID: 15253 Summary: Add Koha::Logger based logging for SIP2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipser to the namespace so we can allow for separate files per sip user if wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45824&action=edit Bug 15253 - Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Add the following to your log4perl.conf: log4perl.logger.sip = DEBUG, SIP log4perl.appender.SIP = Log::Dispatch::Syslog log4perl.appender.SIP.min_level = debug log4perl.appender.SIP.ident = koha_sip log4perl.appender.SIP.facility = local6 log4perl.appender.SIP.layout=PatternLayout log4perl.appender.SIP.layout.ConversionPattern=[%d] [%p] %m %l %n 3) Restart your sip server 4) Tail your syslog, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45825&action=edit Bug 15253 - Log stderr via Koha::Logger as well By logging stderr to the log file, we can much more easily find and debug errors in the SIP server. Stderr has its own category STDERR so these messages can easily be filtered out of the log if need be. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45826&action=edit Bug 15253 - Remove use of syslog -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14167 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 [Bug 14167] Add Koha::Logger based on Log4perl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Is this a bit cumbersome? what about starting by passing Log4perl to the Net::Server config it already supports it its the Koha calls to syslog that stop us enabling it. Coud we not then just call up logger rather than passing $self->server about all the time which looks a bit clumsy -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org