[Bug 14624] New: <<items.content>> for advance_notices.pl wrongly documented
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Bug ID: 14624 Summary: <<items.content>> for advance_notices.pl wrongly documented Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Dokumentation states: 143 =item E<lt>E<lt>items.contentE<gt>E<gt> 144 145 one line for each item, each line containing a tab separated list of 146 title, author, barcode, issuedate Code states: 170 my $itemscontent = join(',',qw( date_due title author barcode )); They don't match! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The documentation of the script and how it works don't match up - we should fix the documentation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 --- Comment #2 from natasha <tasham_8@hotmail.com> --- Created attachment 46843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46843&action=edit Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tasham_8@hotmail.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9499 CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Bug 9499 failed to document it correctly in both places. Line 104 was correct, but line 147 is not. This patch visually fixes that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46843|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47068&action=edit Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47068|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 47173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47173&action=edit Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switched due date for the name of the database column date_due as the parameter expects a list of database column names. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47173|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 47174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47174&action=edit Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switched due date for the name of the database column date_due as the parameter expects a list of database column names. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org