http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10796|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11685&action=edit Bug 8429: Remove unnecessary use of Exporter from SIP/ILS All the modules in the SIP/ILS tree are objects The addition of calls to Exporter or hand manipulation of @ISA added unnecessary bloat Removed the "self = shift or return" idiom as it is nonsensical if the method can only be called via an object. standardized inheritance via use parent added a $self = shift in a couple of places where it was not strictly necessary as its absence seemed to have misled readers in the past Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> ---

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

nice patch!, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 3e771fc Bug 8429: Remove unnecessary use of Exporter from SIP/ILS C4/SIP/ILS/Item.pm C4/SIP/ILS/Patron.pm C4/SIP/ILS/Transaction/Checkin.pm C4/SIP/ILS/Transaction/Checkout.pm C4/SIP/ILS/Transaction/FeePayment.pm C4/SIP/ILS/Transaction/Hold.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm * C4/SIP/ILS/Item.pm OK * C4/SIP/ILS/Patron.pm OK * C4/SIP/ILS/Transaction/Checkin.pm OK * C4/SIP/ILS/Transaction/Checkout.pm OK * C4/SIP/ILS/Transaction/FeePayment.pm OK * C4/SIP/ILS/Transaction/Hold.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11685|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 12333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12333&action=edit Patch rebased against current head Rebased against current head basically the use parent in two files now replaces the use base added by a patch to the renew functionality. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13360&action=edit [SIGNED-OFF] Bug 8429: Remove unnecessary use of Exporter from SIP/ILS All the modules in the SIP/ILS tree are objects The addition of calls to Exporter or hand manipulation of @ISA added unnecessary bloat Removed the "self = shift or return" idiom as it is nonsensical if the method can only be called via an object. standardized inheritance via use parent added a $self = shift in a couple of places where it was not strictly necessary as its absence seemed to have misled readers in the past Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Signed off with a caveat. The 'parent' pragma was not part of the perl core until version 5.10.1. Do we require this version of perl? What about installations still stuck on Lenny? I don't know about other distributions perl versions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Component|SIP2 |Architecture, internals, | |and plumbing Patch complexity|--- |Trivial patch Assignee|colin.campbell@ptfs-europe. |gmcharlt@gmail.com |com | QA Contact|mtj@kohaaloha.com | Severity|enhancement |minor --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: patch passed QA already (see comment 3), also had a signoff from chris (from before the rebase) setting passed QA in the name of Mason PS: is it really an ENH ? I think it's more a minor bugfix, so changing severity accordingly -- You are receiving this mail because: You are watching all bug changes.