[Bug 9149] New: Patch 8823 introduces reference to non-existent function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Bug ID: 9149 Summary: Patch 8823 introduces reference to non-existent function Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: dpk@randomnotes.org This patch appears to break koha 3.8.7. The routine GetAuthorizedHeading called in Biblio.pm, or more precisely C4::AuthoritiesMarc::GetAuthorizedHeading does not exist anywhere in the source. This breaks link_bibs_to_authorities.pl and possibly other things. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8823 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Doug Kingston <dpk@randomnotes.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 jane.chang@cwts.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jane.chang@cwts.edu --- Comment #1 from jane.chang@cwts.edu --- I think I have a similar problem. Cannot edit/replace/create records. The following error appeared when trying to save: Undefined subroutine &C4::AuthoritiesMarc::GetAuthorizedHeading called at /usr/share/koha/lib/C4/Biblio.pm line 667. Please help resolve. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 --- Comment #2 from jane.chang@cwts.edu --- Just got a solution from KOHA maintenance. Go to system preferences and look under authorities tab. Turn "AutoCreateAuthoritie" to "do not generate". This fixed my problem, and hopefully it will fix yours. In the meantime, they will fix the bug for the next update. You can turn it back on after it's fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- 216251e52467cfa3540f16c816ba94c5c0bd499d is the first bad commit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13788&action=edit Bug 9149: Add missing GetAuthorizedHeading On 3.8.x, it was possible for multiple automatically generated authorities to be linked to a single heading. This patch deletes previous links from headings prior to linking them to automatically-generated headings. This patch also corrects a potential problem wherein multiple authorities might be generated if a record is edited repeatedly in quick succession. The latter problem exists on Master and 3.6.x as well, and the code that corrects the multiple linkages is equally applicable if seemingly unnecessary. This patch adds a missing routine to C4::AuthoritiesMarc that should have been in the 3.8.x version of the patch for bug 8823. To test: 1) Turn on BiblioAddsAuthorities and AutoCreateAuthorities. 2) Create a new record or edit an existing one, and add an authority-controlled heading (for example, MARC21 1xx or 6xx or UNIMARC 6xx or 7xx) which does not currently exist in your authority file. 3) If you don't get a software error, it worked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|major |critical --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Could I please get a signoff on this as soon as possible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13788|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13792&action=edit [SIGNED-OFF] [3.8.x] Bug 9149: Add missing GetAuthorizedHeading On 3.8.x, it was possible for multiple automatically generated authorities to be linked to a single heading. This patch deletes previous links from headings prior to linking them to automatically-generated headings. This patch also corrects a potential problem wherein multiple authorities might be generated if a record is edited repeatedly in quick succession. The latter problem exists on Master and 3.6.x as well, and the code that corrects the multiple linkages is equally applicable if seemingly unnecessary. This patch adds a missing routine to C4::AuthoritiesMarc that should have been in the 3.8.x version of the patch for bug 8823. To test: 1) Turn on BiblioAddsAuthorities and AutoCreateAuthorities. 2) Create a new record or edit an existing one, and add an authority-controlled heading (for example, MARC21 1xx or 6xx or UNIMARC 6xx or 7xx) which does not currently exist in your authority file. 3) If you don't get a software error, it worked. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> For 2) you can also download a record over Z39.50. Passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 --- Comment #7 from Doug Kingston <dpk@randomnotes.org> --- I can confirm that this patch fixes the issue and life is more wonderful. :-) Thanks for the quick response. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org