http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Severity|enhancement |minor --- Comment #2 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I set this as bug minor. I have a patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 25845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25845&action=edit Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25845|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25954&action=edit Bug 11366 - Acq basket group "No group" untranslatable in Acq baskets, there's a pull-down for basket groups. One of the entries in that pull-down is "No group", which is untranslatable. This string is hard-coded in perl. This patch removes the string from perl to set it has first option in select. To allow it to be default value, the option "Add new group" is moved to last position. Test plan : - Go to a closed aquisition basket in no basket group : cgi-bin/koha/acqui/basket.pl?basketno=x => You see "No group" selected in combobox "Basket group" - Cick on this combobox => You see "No group", then existing basket groups and then "Add new group" - Select a basket group and click on "change basket group" => You see the basket group name in combobox Use translation, for example fr-FR - go to src/misc/translator - run : perl translate update fr-FR => You find in PO file : #: intranet-tmpl/prog/en/modules/acqui/basket.tt:365 #, fuzzy, c-format msgid "No group" msgstr "Nom de groupe" - remove ", fuzzy" and correct translation : "Pas de groupe" - run : perl translate install fr-FR - Go to translated aquisition basket page => You see translated option in combobox Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.