[Bug 11647] New: Subscribe to email notification for serials needs user login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Bug ID: 11647 Summary: Subscribe to email notification for serials needs user login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org It should be mandatory to be logged in on OPAC to subscribe to email notification on new issues for a serial. This patch does that. To test : - find a serial with notification allowed - display it on OPAC without being logged in - click on Subscriptions > Mode details > Subscribe to email notification Without patch, opac-alert-subscribe.pl is displaid and you can confirm your subscription, but as you are not loggued in, nothing happens and you've got no warning With the patch, Koha asks you to login before asking confirmation for subscription. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Assignee|oleonard@myacpl.org |sophie.meynieux@biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 24933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24933&action=edit Bug 11647 : Subscription for email notification on serials asks for login before proceeding -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24933|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 24979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24979&action=edit Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, there is something that seems not quite right: 1) Searched for a subscription with patron notification active 2) Logged out of the OPAC 3) Subscribed to the patron notification - it showed the "subscribe" link 4) Logged out of the OPAC again 5) Subscription now always shows "cancel subscription", even when I open the page in another browser 6) Logging in with another user account, who hasn't subscribed the alert yet, I am still asked to unsubscribe instead of subscribing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 26041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26041&action=edit Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Add a follow up to deal with Katrin objection -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by remy juliette <remy.gonzalves@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26079&action=edit Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26080&action=edit Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I found another complication with this: 1) Subscribe to email alerts 2) Log out of the OPAC 3) Go back to the subscription link - it shows 'subscribe...' 4) Click on the link, it prompts to log you in 5) Log in 6) ... you can subscribe again, there is no note, that you already are subscribed to this alert (not quite ok) 7) Check the subscribers list - the borrower now is subscribed twice to the same (not ok) 8) Receive a new issue - 2 emails are sent out (not ok) 9) Unsubscribe - both subscriptions are deleted (ok) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #10 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 26186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26186&action=edit Bug 11647 : (follow-up) Add template modification for bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Template modification was missing for bootstrap theme. This last follow-up adds it. Test plan is the same, with your template system preference on "bootstrap" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Aurélie Fichot <aurelie.fichot@iepg.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aurelie.fichot@iepg.fr --- Comment #12 from Aurélie Fichot <aurelie.fichot@iepg.fr> --- It works ! The plan test is OK. cf comment 9 : 6) ... you can't subscribe again, there is a warm that you already are subscribed to this alert 7) Check the subscribers list - the borrower now is subscribed once 8) Receive a new issue - 1 email is sent out 9) Unsubscribe - the subscription is deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aurelie Fichot <aurelie.fichot@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #14 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26197&action=edit Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26198&action=edit Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26199&action=edit Bug 11647 : (follow-up) Add template modification for bootstrap theme Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26228&action=edit [PASSED QA] Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Instead of hiding the feature completely, now a message tells the user to login to subscribe to the email notifications. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26229&action=edit [PASSED QA] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26230&action=edit [PASSED QA] Bug 11647 : (follow-up) Add template modification for bootstrap theme Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11647 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org