https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64105&action=edit Bug 18759: Try to fix random failure from Circulation.t Circulation.t is failing randomly on our CI https://jenkins.koha-community.org/job/Koha_Master_D8/192/console # Failed test at t/db_dependent/Circulation.t line 1147. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1152. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1156. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1170. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1184. # got: '1' # expected: '0' # Looks like you failed 5 tests of 23. Sometimes one of the alert or impossible flags is set. This patch guesses that it's because of the 'restricted' value of the item that is evaluated to 1. If it is not fixed by this patch, we will have more info next time (at least know if alert or impossible is set). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64105|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64107&action=edit Bug 18759: Try to fix random failure from Circulation.t Circulation.t is failing randomly on our CI https://jenkins.koha-community.org/job/Koha_Master_D8/192/console # Failed test at t/db_dependent/Circulation.t line 1147. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1152. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1156. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1170. # got: '1' # expected: '0' # Failed test at t/db_dependent/Circulation.t line 1184. # got: '1' # expected: '0' # Looks like you failed 5 tests of 23. Sometimes one of the alert or impossible flags is set. This patch guesses that it's because of the 'restricted' value of the item that is evaluated to 1. If it is not fixed by this patch, we will have more info next time (at least know if alert or impossible is set). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> The fix is trivial. Using random data will lead to this situations. The good thing is that it lets us spot places in which tests need more fine-grained data. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5)

Without and with this patch:

t/db_dependent/Circulation.t (Wstat: 768 Tests: 95 Failed: 3) Failed tests: 90, 92, 94

Ha! How do you recreate? Could you dump the %alerts and %impossible to know which keys are set? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Subtest: CanBookBeIssued + Koha::Patron->is_debarred|has_overdues Dumper($question,$alerts); L1320:$VAR1 = { 'BORRNOTSAMEBRANCH' => 'HV6N7TZ', 'USERBLOCKEDOVERDUE' => 1 }; $VAR2 = {}; # Looks like you failed 4 tests of 8. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, your errors look different that ones from Jenkins. Yours should be fixed with this patch (I recreated mocking IndependentBranches=1) Last patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)

Marcel, your errors look different that ones from Jenkins. Yours should be fixed with this patch (I recreated mocking IndependentBranches=1)

Last patch pushed to master!

Yeah. That was enough. Thx -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 [Bug 19009] Circulation.t is still failing randomly -- You are receiving this mail because: You are watching all bug changes.