[Bug 12534] New: PROG/CCSR deprecation: Make getlanguages() theme independent for opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bug ID: 12534 Summary: PROG/CCSR deprecation: Make getlanguages() theme independent for opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr getlanguages() function on C4/Languages.pm has a hardcoded reference to 'prog' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29533&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() for opac when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use 'opacthemes' syspref. To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29533|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29555&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29555|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29608&action=edit Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29608|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29641&action=edit [PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org