[Bug 11349] New: PROG/CCSR deprecation: Remove .tmpl -> .tt translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Bug ID: 11349 Summary: PROG/CCSR deprecation: Remove .tmpl -> .tt translation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Blocks: 11346 bootstrap should not have any .tmpl files, so no need to keep the code that does that translation anymore. We should get rid of it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29582&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29583&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29584&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- A messy little conflict on admin/z3950servers.pl otherwise seems fine. Happy to try sign off again when the conflict is tidied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29582|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29773&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29583|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29774&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29584|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 29775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29775&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29773|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29776&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29774|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29777&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29775|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29778&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29776|0 |1 is obsolete| | Attachment #29777|0 |1 is obsolete| | Attachment #29778|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29782&action=edit Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29783&action=edit Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29784&action=edit Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29785&action=edit Bug 11349: (qa follow-up) Fix pod FAIL cataloguing/value_builder/unimarc_field_125.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_125.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_125.pl FAIL cataloguing/value_builder/unimarc_field_126b.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_126b.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_126b.pl FAIL cataloguing/value_builder/unimarc_field_225a.pl FAIL pod *** ERROR: =over on line 40 without closing =back (at head1) in file cataloguing/value_builder/unimarc_field_225a.pl *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_225a.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added a new test in qa tests. commit dacebd6ee4c5df57f0b2ee266e8f425feaee176f Author: Jonathan Druart <jonathan.druart@biblibre.com> Date: Thu Jul 17 11:12:38 2014 +0200 template name should not contain .tmpl anymore -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org