[Bug 42294] New: Tidy all script tags - patron searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Bug ID: 42294 Summary: Tidy all script tags - patron searches Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196805&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196806&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Patch from commit d596d0f -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196811&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196806|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196812&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Patch from commit e30ded0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196811|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196919&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196812|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196920&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Patch from commit b69f13c -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de Depends on| |42295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42295 [Bug 42295] Tidy all script tags - includes staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196919|0 |1 is obsolete| | Attachment #196920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201896&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201897&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201898&action=edit Bug 42294: (follow-up): Fix singleBranchMode singleBranchMode is defined in js_includes. It is also not a system preference and therefore removed from patron-search.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #10 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201899&action=edit Bug 42294: (follow-up): add patron_search_url to Koha.patron_searches object As each patron search has its own search base (defined by patron_search_url) it has to be set and retrieved via the new Koha.patron_searches object This would only affect pages with two patron searches like /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #11 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201900&action=edit Bug 42294: (follow-up) Fix order_column_index loop count As TT loop starts with 1 and JS forEach starts with 0, the '-1' is not necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #12 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201901&action=edit Bug 42294: (follow-up) Fix initialisation of empty arrays in patron-search.inc When actions was not defined on template call (f.e. reserve/request.pl) it resolved to an empty string. This finally led to 'ARRAY(0x55c8872a7130)' interpolated in the template. This patch surrounds the brackets with single quotes so that the expression evaluates to an empty JS array. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Bug 42294 depends on bug 41653, which changed state. Bug 41653 Summary: Stores for permissions and sysprefs should be under the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201896|0 |1 is obsolete| | Attachment #201897|0 |1 is obsolete| | Attachment #201898|0 |1 is obsolete| | Attachment #201899|0 |1 is obsolete| | Attachment #201900|0 |1 is obsolete| | Attachment #201901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204076&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204077&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204078&action=edit Bug 42294: (follow-up): Fix singleBranchMode singleBranchMode is defined in js_includes. It is also not a system preference and therefore removed from patron-search.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204079&action=edit Bug 42294: (follow-up): add patron_search_url to Koha.patron_searches object As each patron search has its own search base (defined by patron_search_url) it has to be set and retrieved via the new Koha.patron_searches object This would only affect pages with two patron searches like /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204080&action=edit Bug 42294: (follow-up) Fix order_column_index loop count As TT loop starts with 1 and JS forEach starts with 0, the '-1' is not necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204081&action=edit Bug 42294: (follow-up) Fix initialisation of empty arrays in patron-search.inc When actions was not defined on template call (f.e. reserve/request.pl) it resolved to an empty string. This finally led to 'ARRAY(0x55c8872a7130)' interpolated in the template. This patch surrounds the brackets with single quotes so that the expression evaluates to an empty JS array. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40626 [Bug 40626] Edit button in item holdings table on bib details page should offer the same options as on Manage Items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204076|0 |1 is obsolete| | Attachment #204077|0 |1 is obsolete| | Attachment #204078|0 |1 is obsolete| | Attachment #204079|0 |1 is obsolete| | Attachment #204080|0 |1 is obsolete| | Attachment #204081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205248&action=edit Bug 42294: Tidy all script tags - patron searches In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the patron searches. Non-trivial changes! The hardest part was to make sure the 2 patron searches on the edit fund view were still working correctly (owner and users) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205249&action=edit Bug 42294: Tidy all script tags - patron searches (auto tidy) Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205250&action=edit Bug 42294: (follow-up): Fix singleBranchMode singleBranchMode is defined in js_includes. It is also not a system preference and therefore removed from patron-search.inc. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205251&action=edit Bug 42294: (follow-up): add patron_search_url to Koha.patron_searches object As each patron search has its own search base (defined by patron_search_url) it has to be set and retrieved via the new Koha.patron_searches object This would only affect pages with two patron searches like /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=1 Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205252&action=edit Bug 42294: (follow-up) Fix order_column_index loop count As TT loop starts with 1 and JS forEach starts with 0, the '-1' is not necessary. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42294 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205253&action=edit Bug 42294: (follow-up) Fix initialisation of empty arrays in patron-search.inc When actions was not defined on template call (f.e. reserve/request.pl) it resolved to an empty string. This finally led to 'ARRAY(0x55c8872a7130)' interpolated in the template. This patch surrounds the brackets with single quotes so that the expression evaluates to an empty JS array. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org