[Bug 36482] New: Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Bug ID: 36482 Summary: Make it possible to embed desks and cash_registers on /libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED Depends on| |36480, 36481 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Now that we have specs thanks to bug 36480 and bug 36481, we should add the option. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 [Bug 36480] Add GET /libraries/:library_id/desks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 [Bug 36481] Add GET /libraries/:library_id/cash_registers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164229&action=edit Bug 36482: Allow embedding desks and cash_registers on libraries endpoints Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164230&action=edit Bug 36482: Make embedding work for GET /libraries/:library_id Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36483 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Not sure how to test this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 [Bug 36495] Add resource_not_found() and resource_deleted() helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #4)
Not sure how to test this one.
Sorry for that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- To test: 1. Have UseCirculationDesks and UseCashRegisters enabled 2. Add some cash registers and desks to a known KTD library. For example 'MPL'. 3. Use Postman to make: * GET /libraries * GET /libraries/MPL in both cases add the request header 'x-koha-embed: desks,cash_registers' => FAIL: In both cases the requests are denied because embedding those is not allowed. 4. Apply the first patch 5. Repeat 3 => PARTIAL SUCCESS: GET /libraries does the job! => FAIL: GET /libraries/MPL fails! 6. Apply the second patch and repeat 3 => SUCCESS: Both cases succeed! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164229|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 164304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164304&action=edit Bug 36482: Allow embedding desks and cash_registers on libraries endpoints Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164230|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 164305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164305&action=edit Bug 36482: Make embedding work for GET /libraries/:library_id Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Tomás! Testing notes (using KTD): 1. Also needed to enable RESTBasicAuth system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164304|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164416&action=edit Bug 36482: Allow embedding desks and cash_registers on libraries endpoints Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164305|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164417&action=edit Bug 36482: Make embedding work for GET /libraries/:library_id Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164418&action=edit Bug 36482: Add embed tests prove t/db_dependent/api/v1/libraries.t Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Pedro Amorim from comment #12)
Created attachment 164418 [details] [review] Bug 36482: Add embed tests
prove t/db_dependent/api/v1/libraries.t
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Thanks for the missed tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36480 | CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 [Bug 36480] Add GET /libraries/:library_id/desks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Applying: Bug 36482: Allow embedding desks and cash_registers on libraries endpoints error: sha1 information is lacking or useless (api/v1/swagger/paths/libraries.yaml). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I let Tomas know about this yesterday, I think he's working on it once his jetlag lets his brain work again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164416|0 |1 is obsolete| | Attachment #164417|0 |1 is obsolete| | Attachment #164418|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164929&action=edit Bug 36482: Allow embedding desks and cash_registers on libraries endpoints Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164930&action=edit Bug 36482: Make embedding work for GET /libraries/:library_id Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164931&action=edit Bug 36482: Add embed tests prove t/db_dependent/api/v1/libraries.t Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Back to PQA, trivial conflict with 'library hours' fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Being a little nit-picky, but shouldn't this be "library default"? + branch_default: + type: boolean + description: If this till is the branch default Adding "additional_work_needed", meaning "Asking for feedback". Not a blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Bug 36482 depends on bug 36481, which changed state. Bug 36481 Summary: Add GET /libraries/:library_id/cash_registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org