https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 159807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159807&action=edit Bug 35559 - Allow the change of expiration date on the last day of expiration The result of this comparison will almost never be 0 as it requires the dates to be same down to a second: DateTime->compare( dt_from_string( $res->expirationdate ), dt_from_string() ) == -1 This patch fixes it. To reproduce: 1) Create or use existing hold that is awaiting pickup. 2) Set it's expiration date to today. (if you can't do it through koha interface, edit it in the database or wait for tomorrow to come) 3) Check that you can't change the expiration date anymore as it says "Expired: %date%" 4) Apply the patch 5) Check that you can change the expiration date -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This creates a bit of a problem on reserve/request.pl with your patched applied. 1. Have a hold that expires today and go to reserve/request.pl for that item. 2. Look at the expiration date column and notice it will be blank. 3. We use data-flatpickr-futuredate on this input and today is not a futuredate. Furthermore, I am not sure I agree with this change. If the expiration date is today I would not considered it "the last day of the pick-up period". I would consider that to be the day before the expirationdate. Also, your bug title is not not correct. Have a look at the QA tool: Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - c2d44aa429 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Mike Barrette <mbarrette@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbarrette@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I've gotten feedback from our staff about this as well - we also don't use the cron for waiting holds, and it is common for staff to grant last-minute extensions if a customer called and asked for one. Incidentally, I also noticed an inconsistency the other day - the expiration dates becomes un-editable on the expiration date of the hold, but holds don't appear on the Holds Over tab until the day after the expiration date. Not sure off the top of my head which way the cron goes, but those three things should be consistent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- It looks like this is a regression (or the indirect result of one), and I think I've tracked down how we got here, but I'm not familiar enough with flatpickr to submit an alternate patch. Hopefully this will be helpful to someone who is: 1. We had a bug in the past, where a flatpickr with futuredate wouldn't display the previously input date (e.g. the expiration date on an expired hold) if that date was in the past. We fixed that in Bug 29241 and its follow-up, Bug 29500. 2. Bug 30718 (Use flatpickr's altInput option everywhere) caused a regression, and the date field on an expired hold (or any other futuredate field with a preexisting date in the past) would show as blank again. 3. Bug 34634 fixed the regression by removing the input field and simply displaying the date if the hold was expired. However, some library staff are accustomed to extending holds on or after the expiration date is reached, so this less than ideal for those workflows. Also, the regression caused by bug 30718 (presumably) still exists for all other futuredate inputs, besides the holds page. So it would be ideal if we can fix that underlying regression and allow editing of the dates on expired holds. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 163743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163743&action=edit Bug 35559: Correctly parse previous flatpickr date The Flatpickr configuration for futuredate and futuredateinclusive is meant to allow the preexisting date, even if it is in the past, to avoid data loss. As of Bug 30718 - Use flatpickr's alt option everywhere, that incoming date is in yyyy-mm-dd format, not the configured human-readable format, and needs to be parsed accordingly. To test: 1. Place 2 holds on the same bib, both with an expiration date set 2. Set the expiration date for one of the holds to a date in the past (e.g., in Koha Testing Docker, use the commands: ktd --shell koha-mysql kohadev to access the database directly) 3. Reload the holds tab for that bib --> Note that the future expiration date will be editable, and the past expiration date will not be editable 4. In a new tab, go to Administration > Patron Categories 5. Edit one patron category to have an enrolment period date in the future 6. Edit another patron category to have an enrolment period date in the past (e.g. by accessing the database directly, as above) 7. Reload the Edit pages for each of the above categories (in new tabs) --> Note that the future enrolment period date will be retained in the date field, but the past enrolment period date will be blanked out 8. Apply this patchset 9. Refresh the holds tab from step 3 --> Note that both expiration dates are now editable 10. Refresh the 2 patron category tabs from step 7 --> Note that both enrolment dates are now retained correctly 11. Open the date picker on one of the date fields that has a past date --> Note that other past dates, besides the existing date, are prevented -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163743|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165909&action=edit Bug 35559: Correctly parse previous flatpickr date The Flatpickr configuration for futuredate and futuredateinclusive is meant to allow the preexisting date, even if it is in the past, to avoid data loss. As of Bug 30718 - Use flatpickr's alt option everywhere, that incoming date is in yyyy-mm-dd format, not the configured human-readable format, and needs to be parsed accordingly. To test: 1. Place 2 holds on the same bib, both with an expiration date set 2. Set the expiration date for one of the holds to a date in the past (e.g., in Koha Testing Docker, use the commands: ktd --shell koha-mysql kohadev to access the database directly) 3. Reload the holds tab for that bib --> Note that the future expiration date will be editable, and the past expiration date will not be editable 4. In a new tab, go to Administration > Patron Categories 5. Edit one patron category to have an enrolment period date in the future 6. Edit another patron category to have an enrolment period date in the past (e.g. by accessing the database directly, as above) 7. Reload the Edit pages for each of the above categories (in new tabs) --> Note that the future enrolment period date will be retained in the date field, but the past enrolment period date will be blanked out 8. Apply this patchset 9. Refresh the holds tab from step 3 --> Note that both expiration dates are now editable 10. Refresh the 2 patron category tabs from step 7 --> Note that both enrolment dates are now retained correctly 11. Open the date picker on one of the date fields that has a past date --> Note that other past dates, besides the existing date, are prevented Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35977 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've made the same fix for the OPAC now in the follow-up on bug 35977 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin@gmail.com --- Comment #18 from Slava Shishkin <slavashishkin@gmail.com> --- Our librarians need the ability to choose today's date. This is currently not possible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.