https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174597|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 174600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174600&action=edit Bug 38460: [WIP] Enable translations for authorised values (alternative) As it's a WIP, not every place shows the translated description. One place where it works is the items table in the "edit item" page Test plan: 1. Edit one of LOC authorised values, you should see links to translate descriptions (for both staff and opac) Add translations for a language 2. Switch to this language, if not already done 3. Find a biblio record, edit one of its items and change the loc field to the value you translated. Save. 4. Now in the table at the top of the page you should see the translated description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174601|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180527&action=edit Bug 38460: [WIP] Enable translations for authorised values (alternative) As it's a WIP, not every place shows the translated description. One place where it works is the items table in the "edit item" page Test plan: 1. Edit one of LOC authorised values, you should see links to translate descriptions (for both staff and opac) Add translations for a language 2. Switch to this language, if not already done 3. Find a biblio record, edit one of its items and change the loc field to the value you translated. Save. 4. Now in the table at the top of the page you should see the translated description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Can you rebase please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Patch doesn't apply --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)

We should have a way to inject translations from installer/data/mysql/*/mandatory/auth_values.yml

I am not sure if this is necessary for a first implementation. A lot of the autorised values will be changed by libraries anyway. We could handle it separately I believe. But this patch currently doesn't apply: Applying 1 patch(es): Patch application failed for attachment 180527 - Bug 38460: [WIP] Enable translations for authorised values (alternative) Patches left in /tmp/PrMo3eizbY for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/PrMo3eizbY/0001-180527.patch) failed: error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 196301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196301&action=edit Bug 38460: [WIP] Enable translations for authorised values (alternative) As it's a WIP, not every place shows the translated description. One place where it works is the items table in the "edit item" page Test plan: 1. Edit one of LOC authorised values, you should see links to translate descriptions (for both staff and opac) Add translations for a language 2. Switch to this language, if not already done 3. Find a biblio record, edit one of its items and change the loc field to the value you translated. Save. 4. Now in the table at the top of the page you should see the translated description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- == Test plan == Prerequisites: * Apply patches * Install additional languages, in ktd: sudo koha-translate --install de-DE --dev kohadev * Make sure languages are active in OpacLanguaes and StaffInterfaceLanguages system preferences Configuration: * Edit one of LOC authorised values, you should see links to translate descriptions (for both staff interface and OPAC) Add translations for a language * Search for a bibliographic record and update location to translated location. * Switch to this language, if not already done. Testing: Test the right description/translation shows, when switching between languages in several spots: * Staff Interface * Edit item form: Table on top of the form * OPAC * Detail page / MARC view / items table == Notes from testing == Not working: 1) Breadcrumbs on the translation page are missing parts, only the "last bit" is shown. 2) When looking at the item tables from the test plan, every authorised value that is NULL / "" and not defined explicitly in the AV, now shows "No information available". This should be changed back to show empty cells instead. Working: 1) Fallbacks for existing AV lines: - Only description / translated description = OPAC and staff show the same - description, translated description, OPAC description = OPAC shows OPAC description - OPAC description is also translated = translated OPAC description is used I am not sure how many different ways we have to access and display authorised values, but this seems like a good, even if limited, starting point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38460 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39118 CC| |clemens.tubach@kit.edu, | |katrin.fischer@bsz-bw.de, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.