[Bug 13762] New: biblionumber field and subfield can be called once in authorities merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Bug ID: 13762 Summary: biblionumber field and subfield can be called once in authorities merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In AuthoritiesMarc::merge, the call of GetMarcFromKohaField( "biblio.biblionumber", '' ) is into several foreach loops. This call can be extracted to be executed only once. Also, the biblionumber of each record can be stored in @reccache to avoid finding it twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13760 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 36171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36171&action=edit Bug 13762 - biblionumber field and subfield can be called once in authorities merge In AuthoritiesMarc::merge, the call of GetMarcFromKohaField( "biblio.biblionumber", '' ) is into several foreach loops. This call can be extracted to be executed only once. Also, the biblionumber of each record can be stored in @reccache to avoid finding it twice. Test plan : - Set syspref dontmerge to 'Do' - Merging 2 authoritites - Check linked biblio records are impacted - Change an authority heading - Check linked biblio records are impacted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11700 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Testing this one.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Merged two authority records (A and B; B removed). Had a biblio with 100 linked to auth A and 700 to auth B. After merge and reindex still auth B in the biblio record. (dontmerge=Do) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11700 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org