http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|minor |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45700|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45701&action=edit Bug 15376: Edit invoices: Can not change Shipping cost To reproduce: - Go to Home > Acquisitions - Edit an invoice that has no shipping date - Change shipment cost. Leave shipping date empty - Save Result: Page reloads, shipment cost keeps old value. Warnings in intranet-error.log To test: - Apply patch - Follow steps above Result: Shipment costs are changed as expected No warnings in intrante-error.log Additionally, verify that the input field 'Shipping cost' is properly formatted and that in invoice details 'Shipment cost' is replaced by 'Shipping cost' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45701|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45709&action=edit Bug 15376: Edit invoices: Can not change Shipping cost To reproduce: - Go to Home > Acquisitions - Edit an invoice that has no shipping date - Change shipment cost. Leave shipping date empty - Save Result: Page reloads, shipment cost keeps old value. Warnings in intranet-error.log To test: - Apply patch - Follow steps above Result: Shipment costs are changed as expected No warnings in intrante-error.log Additionally, verify that the input field 'Shipping cost' is properly formatted and that in invoice details 'Shipment cost' is replaced by 'Shipping cost' Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Confirm bug and solution -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 45718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45718&action=edit Bug 15376: (followup) Set on_editing flag See comment #4 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I followed the test plan. And can (also) change the shipping cost for an invoice without shipment date in current master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 --- Comment #9 from Marc Véron <veron@veron.ch> --- The error no longer appears on current master. I had a look at the database: When I filed the bug, the error occured with records where shipmentdate = NULL. The current behaviour is that a record with shipmentdate = NULL has now shipmentdate = 0000-00-00 after saving with an empty field 'shipmentdate'. More testing: If I receive a shipment and save with an empty shipmentdate, the shipmentdate gets a NULL in the database (and billingdate / closedate as well). Additionally: If I edit this record and save it without changing any values (leaving shipmentdate and billingdate empty), shipmentdate turns to 0000-00-00 but billingdate is still NULL. I would expect that both dates behave the same. (BTW: While saving I get a log entry 'invoice.pl: Use of uninitialized value in concatenation (.) or string at .../invoice.tt line 79) So we have two different values for "empty date" in the table aqinvoices: NULL and 0000-00-00. @Jonathan: What dou you think about 0000-00-00 vs NULL? If I look at Bugzilla I see a couple of Bugs regarding 0000-00-00. -- You are receiving this mail because: You are watching all bug changes.