[Bug 33686] New: Update plugin unimarc_field_110.pl 'Script of title' with 2022 values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Bug ID: 33686 Summary: Update plugin unimarc_field_110.pl 'Script of title' with 2022 values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Hello all, Update of the data with the values introduced in 2022 concerning unimarc_field_110.pl Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150714&action=edit Bug 33686: Update plugin unimarc_field_110.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150714|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150790&action=edit Bug 33686: Update plugin unimarc_field_110.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, as this adds the new values in the 2022 UNIMARC update. However, I do have a question: should the script of title name values match exactly with the UNIMARC definitions (see references)? For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), but in Koha it is shown as eg Dongba (Naxi). If they should, I'm happy to create a bug for that. References: 1. UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-upd... 2. Tag 100 values (see page 8 for 'Script of title') https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Testing notes (using KTD): 1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc 2. Edit a record and view the values for tag 100 and the 'Script of title' dropdown list. 3. Codes and names for values being added by this bug are not listed. 4. Apply the patch. 5. Restart everything (flush_memcached, restart_all, clear browser cache). 6. Repeat step 2. 7. New codes and values are now lsited. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update plugin |Update plugin |unimarc_field_110.pl |unimarc_field_100.pl |'Script of title' with 2022 |'Script of title' with 2022 |values |values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Comment on attachment 150790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150790 Bug 33686: Update plugin unimarc_field_110.pl with 2022 values
From 0fc81a34b3ff8e6eaf1b1270282a31cfc8453c8b Mon Sep 17 00:00:00 2001 From: Thibaud Guillot <thibaud.guillot@biblibre.com> Date: Fri, 5 May 2023 13:01:23 +0200 Subject: [PATCH] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Was missing :
- ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze)
Sponsored by BibLibre
Signed-off-by: David Nind <david@davidnind.com> --- .../value_builder/unimarc_field_100.tt | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt index 103e8949cc..23e43cff13 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt @@ -685,6 +685,16 @@ [% ELSE %] <option value="ia">ia- Thai</option> [% END %] + [% IF ( f15ib ) %] + <option value="ib" selected="selected">ib- Birman</option> + [% ELSE %] + <option value="ib">ib- Birman</option> + [% END %] + [% IF ( f15ic ) %] + <option value="ic" selected="selected">ic- Khmer</option> + [% ELSE %] + <option value="ic">ic- Khmer</option> + [% END %] [% IF ( f15id ) %] <option value="id" selected="selected">id- Laotian</option> [% ELSE %] @@ -700,6 +710,26 @@ [% ELSE %] <option value="ja">ja- Devanagari</option> [% END %] + [% IF ( f15jb ) %] + <option value="jb" selected="selected">jb- Bengali</option> + [% ELSE %] + <option value="jb">jb- Bengali</option> + [% END %] + [% IF ( f15jc ) %] + <option value="jc" selected="selected">jc- Gujurati</option> + [% ELSE %] + <option value="jc">jc- Gujurati</option> + [% END %] + [% IF ( f15jd ) %] + <option value="jd" selected="selected">jd- Gurmukhi</option> + [% ELSE %] + <option value="jd">jd- Gurmukhi</option> + [% END %] + [% IF ( f15je ) %] + <option value="je" selected="selected">je- Odia (oriya)</option> + [% ELSE %] + <option value="je">je- Odia (oriya)</option> + [% END %] [% IF ( f15jf ) %] <option value="jf" selected="selected">jf- Tibetan</option> [% ELSE %] @@ -720,6 +750,26 @@ [% ELSE %] <option value="la">la- Tamil</option> [% END %] + [% IF ( f15lb ) %] + <option value="lb" selected="selected">lb- Kannada (kannara)</option> + [% ELSE %] + <option value="lb">lb- Kannada (kannara)</option> + [% END %] + [% IF ( f15lc ) %] + <option value="lc" selected="selected">lc- Malayalam</option> + [% ELSE %] + <option value="lc">lc- Malayalam</option> + [% END %] + [% IF ( f15ld ) %] + <option value="ld" selected="selected">ld- Singhalais (cinghalais)</option> + [% ELSE %] + <option value="ld">ld- Singhalais (cinghalais)</option> + [% END %] + [% IF ( f15le ) %] + <option value="le" selected="selected">le- Tégoulou</option> + [% ELSE %] + <option value="le">le- Tégoulou</option> + [% END %] [% IF ( f15lf ) %] <option value="lf" selected="selected">lf- Grantha</option> [% ELSE %] @@ -735,6 +785,11 @@ [% ELSE %] <option value="mb">mb- Armenian</option> [% END %] + [% IF ( f15na ) %] + <option value="na" selected="selected">na- Ethiopien (guèze)</option> + [% ELSE %] + <option value="na">na- Ethiopien (guèze)</option> + [% END %] [% IF ( f15nb ) %] <option value="nb" selected="selected">nb- Tifinagh (Berber alphabet)</option> [% ELSE %] -- 2.30.2
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150790|Bug 33686: Update plugin |Bug 33686: Update plugin description|unimarc_field_110.pl with |unimarc_field_100.pl with |2022 values |2022 values Attachment #150790|Bug-33686-Update-plugin-uni |Bug-33686-Update-plugin-uni filename|marcfield110pl-with-202.pat |marcfield100pl-with-202.pat |ch |ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150933&action=edit Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Did test it now under MySQL 8. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150934&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150790|0 |1 is obsolete| | Attachment #150933|0 |1 is obsolete| | --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150935&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150934|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150936&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150935|0 |1 is obsolete| | Attachment #150936|0 |1 is obsolete| | --- Comment #9 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150937&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 150938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150938&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #11 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #3)
I've signed off, as this adds the new values in the 2022 UNIMARC update.
However, I do have a question: should the script of title name values match exactly with the UNIMARC definitions (see references)?
For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), but in Koha it is shown as eg Dongba (Naxi).
If they should, I'm happy to create a bug for that.
References: 1. UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with- updates/ 2. Tag 100 values (see page 8 for 'Script of title') https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
Testing notes (using KTD): 1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc 2. Edit a record and view the values for tag 100 and the 'Script of title' dropdown list. 3. Codes and names for values being added by this bug are not listed. 4. Apply the patch. 5. Restart everything (flush_memcached, restart_all, clear browser cache). 6. Repeat step 2. 7. New codes and values are now lsited.
Hello David, Indeed there are some terms which are not exactly the same as those of the ifla document, I propose a correction of those in a differentiated commit (only concerning the section "Script of title" to be precise with the BZ title). I took the opportunity to change the title of the BZ, there was an error concerning the value builder, it is 100 and not 110 as previously indicated. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150937|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 151178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151178&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150938|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 151179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151179&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151178|0 |1 is obsolete| | Attachment #151179|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151340&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151341&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org