https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33957 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152160&action=edit Bug 33957: Add normalized_oclc and only fetch when needed opac-user.tt wants to normalized_oclc number if using syndetics or B&T images We don't need to fetch it if not, but we need to pass it if so To test: 1 - Switch all Syndetics prefs to 'Show' or 'Use' except SyndeticsClientCode = just enter 'test' 2 - Checkout some items to a patron, ensure the records have: - ISBN - UPC - OCLC number 3 - View opac-user.pl (sign in to opac as the user) 4 - View the network console tab (may need to reload) 5 - Note requests like: https://secure.syndetics.com/index.aspx?isbn=1780335792/MC.GIF&client=test&type=xw10&upc=&oclc= 6 - Note that oclc parameter is not filled for record with an oclc number 7 - Apply patch 8 - Reload 9 - Confirm the link now has oclc as expected 10 - Disable syndetics, enable google books or another source 11 - Confirm images display as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33957 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152160|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152193&action=edit Bug 33957: Add normalized_oclc and only fetch when needed opac-user.tt wants to normalized_oclc number if using syndetics or B&T images We don't need to fetch it if not, but we need to pass it if so To test: 1 - Switch all Syndetics prefs to 'Show' or 'Use' except SyndeticsClientCode = just enter 'test' 2 - Checkout some items to a patron, ensure the records have: - ISBN - UPC - OCLC number 3 - View opac-user.pl (sign in to opac as the user) 4 - View the network console tab (may need to reload) 5 - Note requests like: https://secure.syndetics.com/index.aspx?isbn=1780335792/MC.GIF&client=test&type=xw10&upc=&oclc= 6 - Note that oclc parameter is not filled for record with an oclc number 7 - Apply patch 8 - Reload 9 - Confirm the link now has oclc as expected 10 - Disable syndetics, enable google books or another source 11 - Confirm images display as expected JD amended patch: tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33957 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33957 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33957 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.