[Bug 33104] New: Add vendor Interfaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Bug ID: 33104 Summary: Add vendor Interfaces Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147632&action=edit Bug 33104: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147633&action=edit Bug 33104: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147634&action=edit Bug 33104: Koha classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147635&action=edit Bug 33104: Add the ability to create vendor interfaces This patchset is adding the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. It will help librarians to keep track of those different information within Koha. * new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri, login, password, account_email, notes) * new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN, ORDERS, REPORTS * new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s] * new method to retrieve the interfaces from the vendor Koha::Acquisition::Bookseller->interfaces * Add/Delete interfaces when editing a vendor * Display the interfaces on the vendor show view Test plan: - Add a new vendor => Notice the new "Interfaces" block - Create some interfaces => They are display on the vendor show view => The password is hashed and can displayed on the demand QA Note: The "contacts" code is not very nice and I didn't want to replicate it, so I went another way and tried to make the code reusable, for further reutilisation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147636&action=edit Bug 33104: Make the code reusable We could then reuse it for the contacts code in this same template, on another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147637&action=edit Bug 33104: Encrypt password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147638&action=edit Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147639&action=edit Bug 33104: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 [Bug 33103] Add vendor aliases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147632|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148459&action=edit Bug 33104: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147633|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148460&action=edit Bug 33104: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147634|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148461&action=edit Bug 33104: Koha classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147635|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148462&action=edit Bug 33104: Add the ability to create vendor interfaces This patchset is adding the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. It will help librarians to keep track of those different information within Koha. * new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri, login, password, account_email, notes) * new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN, ORDERS, REPORTS * new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s] * new method to retrieve the interfaces from the vendor Koha::Acquisition::Bookseller->interfaces * Add/Delete interfaces when editing a vendor * Display the interfaces on the vendor show view Test plan: - Add a new vendor => Notice the new "Interfaces" block - Create some interfaces => They are display on the vendor show view => The password is hashed and can displayed on the demand QA Note: The "contacts" code is not very nice and I didn't want to replicate it, so I went another way and tried to make the code reusable, for further reutilisation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147636|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148463&action=edit Bug 33104: Make the code reusable We could then reuse it for the contacts code in this same template, on another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147637|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148464&action=edit Bug 33104: Encrypt password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147638|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148465&action=edit Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147639|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148466&action=edit Bug 33104: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148459|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148473&action=edit Bug 33104: DB changes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148460|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148474&action=edit Bug 33104: DBIC changes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148461|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148475&action=edit Bug 33104: Koha classes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148462|0 |1 is obsolete| | --- Comment #20 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148476&action=edit Bug 33104: Add the ability to create vendor interfaces This patchset is adding the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. It will help librarians to keep track of those different information within Koha. * new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri, login, password, account_email, notes) * new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN, ORDERS, REPORTS * new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s] * new method to retrieve the interfaces from the vendor Koha::Acquisition::Bookseller->interfaces * Add/Delete interfaces when editing a vendor * Display the interfaces on the vendor show view Test plan: - Add a new vendor => Notice the new "Interfaces" block - Create some interfaces => They are display on the vendor show view => The password is hashed and can displayed on the demand QA Note: The "contacts" code is not very nice and I didn't want to replicate it, so I went another way and tried to make the code reusable, for further reutilisation. Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148463|0 |1 is obsolete| | --- Comment #21 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148477&action=edit Bug 33104: Make the code reusable We could then reuse it for the contacts code in this same template, on another bug report. Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148464|0 |1 is obsolete| | --- Comment #22 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148478&action=edit Bug 33104: Encrypt password Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148465|0 |1 is obsolete| | --- Comment #23 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148479&action=edit Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148466|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148480&action=edit Bug 33104: Add tests Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #25 from David Nind <david@davidnind.com> --- It looks like this has now been signed off by Jonathan. Jonathan, if you could update the status that would be great! (This credits you on the dashboard for the sign-off). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Jonathan Field <jonathan.field@ptfs-europe.com> --- Sorry, forgot to do that at the end! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #27 from David Nind <david@davidnind.com> --- (In reply to Jonathan Field from comment #26)
Sorry, forgot to do that at the end! Thanks!
8-) No problem! I've certainly forgotten to do this on occasion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Add vendor Interfaces |Add vendor interfaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) I18N ol.append(`<li><button class="btn btn-default" onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete interface</li>`); 2) Vendor search * I am seeing a strange effect there: the "My Vendor" vendor with booksellerid=1 is showing up twice after applying the patch. Switching back to master makes the doubled up vendor go away. 3) Vendor edit form * Adding the email validation to the email field would be good. * If you add multiple interfaces, the type pull down empties/resets to "" for all interfaces when clicking on "Add another interface". This also happens to the already saved interfaces. 4) Vendor details page * The new information is not displaying correctly (see screenshot). I did a yarn build and reset_all, nothing would fix. Background is wrong and also the line height doesn't match with the other sections on the page. 5) Database update and sample data * This appears complete and correct :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149375&action=edit Screenshot of vendor detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #28)
1) I18N
ol.append(`<li><button class="btn btn-default" onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete interface</li>`);
Fixed.
2) Vendor search
* I am seeing a strange effect there: the "My Vendor" vendor with booksellerid=1 is showing up twice after applying the patch. Switching back to master makes the doubled up vendor go away.
Fixed on bug 33103.
3) Vendor edit form
* Adding the email validation to the email field would be good.
Done in "Add email validation"
* If you add multiple interfaces, the type pull down empties/resets to "" for all interfaces when clicking on "Add another interface". This also happens to the already saved interfaces.
Done in "Prevent 'Type' to be cleared
4) Vendor details page
* The new information is not displaying correctly (see screenshot). I did a yarn build and reset_all, nothing would fix. Background is wrong and also the line height doesn't match with the other sections on the page.
What are you suggesting? I think this is nicer than the others :D https://snipboard.io/Iwetbx.jpg Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149420&action=edit Bug 33104: Fix translatability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149421&action=edit Bug 33104: Add email validation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149422&action=edit Bug 33104: Prevent 'Type' to be cleared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149431&action=edit Bug 33104: Remove fieldset For consistency with "Contacts" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #30)
What are you suggesting? I think this is nicer than the others :D
https://snipboard.io/Iwetbx.jpg
Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read).
See last patch. Better for consistency, but IMO it was nicer prior to this patch (except the background weirdness) https://snipboard.io/jv7yIe.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33499 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 [Bug 33499] Improve styling of vendor detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #35)
(In reply to Jonathan Druart from comment #30)
What are you suggesting? I think this is nicer than the others :D
https://snipboard.io/Iwetbx.jpg
Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read).
See last patch. Better for consistency, but IMO it was nicer prior to this patch (except the background weirdness)
I've filed bug 33499 for improving the vendor detail page. Otherwise... PQA now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148473|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149492&action=edit Bug 33104: DB changes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148474|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149493&action=edit Bug 33104: DBIC changes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148475|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149494&action=edit Bug 33104: Koha classes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148476|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149495&action=edit Bug 33104: Add the ability to create vendor interfaces This patchset is adding the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. It will help librarians to keep track of those different information within Koha. * new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri, login, password, account_email, notes) * new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN, ORDERS, REPORTS * new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s] * new method to retrieve the interfaces from the vendor Koha::Acquisition::Bookseller->interfaces * Add/Delete interfaces when editing a vendor * Display the interfaces on the vendor show view Test plan: - Add a new vendor => Notice the new "Interfaces" block - Create some interfaces => They are display on the vendor show view => The password is hashed and can displayed on the demand QA Note: The "contacts" code is not very nice and I didn't want to replicate it, so I went another way and tried to make the code reusable, for further reutilisation. Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148477|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149496&action=edit Bug 33104: Make the code reusable We could then reuse it for the contacts code in this same template, on another bug report. Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148478|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149497&action=edit Bug 33104: Encrypt password Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148479|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149498&action=edit Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148480|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149499&action=edit Bug 33104: Add tests Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149420|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149500&action=edit Bug 33104: Fix translatability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149421|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149501&action=edit Bug 33104: Add email validation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149422|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149502&action=edit Bug 33104: Prevent 'Type' to be cleared Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149431|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149503&action=edit Bug 33104: Remove fieldset For consistency with "Contacts" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 [Bug 33105] Add vendor Issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149631&action=edit Bug 33104: Rename interfaces.id with interface_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149493|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149632&action=edit Bug 33104: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rename asked by Tomas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #51)
Rename asked by Tomas.
Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Bug 33104 depends on bug 33103, which changed state. Bug 33103 Summary: Add vendor aliases https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement and dependencies are not present.. won't backport to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the ability to release notes| |create interfaces for | |vendors. | |An interface is a | |website, software, or | |portal that you use to | |manage orders or gather | |statistics from the vendor | |or organisation. Interfaces | |can also include usernames | |and passwords, that will be | |encrypted for storage, but | |can be decrypted and made | |visible in the staff | |interface. | |The type of an | |interface can be set using | |the `VENDOR_INTERFACE_TYPE` | |authorised values category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 [Bug 33797] Extra space in supplier.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 [Bug 33798] Vendor details - improve consistency of edit forms and display -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org