[Bug 26684] New: Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Bug ID: 26684 Summary: Remove 'marc' column from auth_header table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org There's no need to have a marc column in the auth_header table anymore. We'll need to change at least the following files: ./installer/data/mysql/kohastructure.sql ./C4/AuthoritiesMarc.pm (AddAuthority, ) t/db_dependent/Linker_FirstMatch.t We'll also need to drop the column using updatedatabase.pl: ./installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Actually, we'll also need to re-generate Koha/Schema/Result/AuthHeader.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 111670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111670&action=edit Bug 26684: Remove marc from auth_header for new installs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 111671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111671&action=edit Bug 26684: Remove marc column from existing databases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 111672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111672&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111670|0 |1 is obsolete| | --- Comment #5 from didier <didier.gautheron@biblibre.com> --- Created attachment 112016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112016&action=edit Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112016|0 |1 is obsolete| | --- Comment #6 from didier <didier.gautheron@biblibre.com> --- Created attachment 112018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112018&action=edit Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111671|0 |1 is obsolete| | --- Comment #7 from didier <didier.gautheron@biblibre.com> --- Created attachment 112019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112019&action=edit Bug 26684: Remove marc column from existing databases Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Qa tools complaints: FAIL installer/data/mysql/atomicupdate/001-26684-drop_marc_column_from_auth_header.pl FAIL critic Code before strictures are enabled at line 1, column 1. See page 429 of PBP. FAIL file permissions File must have the exec flag FAIL valid Name "main::dbh" used only once: possible typo if you move the file to 'perl' many disappear, however, the bug number is missing from the update so it fails right now, also we should check the existence of the column before droppping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112018|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 112087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112087&action=edit Bug 26684: Remove marc from auth_header for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112019|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 112088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112088&action=edit Bug 26684: Remove marc column from existing databases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111672|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 112089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112089&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 112090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112090&action=edit Bug 26684: Fix atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from David Cook <dcook@prosentient.com.au> --- QA scripts and updatedatabase.pl should be happy now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26684: Remove marc from auth_header for new installs Using index info to reconstruct a base tree... M C4/AuthoritiesMarc.pm M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/AuthoritiesMarc.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26684: Remove marc from auth_header for new installs Also, is there a test plan? I have no idea how to test this one... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112087|0 |1 is obsolete| | Attachment #112088|0 |1 is obsolete| | Attachment #112089|0 |1 is obsolete| | Attachment #112090|0 |1 is obsolete| | --- Comment #15 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177445&action=edit Bug 26684: Remove marc from auth_header for new installs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #16 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177446&action=edit Bug 26684: Remove marc column from existing databases -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #17 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177447&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #18 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177448&action=edit Bug 26684: Fix atomic update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #19 from Janusz Kaczmarek <januszop@gmail.com> --- The auth_header.marc column should definitely be remover. It is outdated, never used (only stored), and we have removed marc from biblio long time ago. Morover, it is of size blob (64K), which means it cannot properly host large ISO 2709 records (up to 99K). While saving large records we get warning: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'marc' at row 1 at /kohadevbox/koha/Koha/Object.pm line 172 and creation / modification is not properly performed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #20 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177449&action=edit Bug 26684: Remove marc from Koha::Authority::to_api_mapping -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #21 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177450&action=edit Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc Since we have misc/export_records.pl and we want to remove auth_header.marc, the ancient script misc/exportauth.pl can be removed as well (it is relied upon auth_header.marc). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177445|0 |1 is obsolete| | Attachment #177446|0 |1 is obsolete| | Attachment #177447|0 |1 is obsolete| | Attachment #177448|0 |1 is obsolete| | Attachment #177449|0 |1 is obsolete| | Attachment #177450|0 |1 is obsolete| | --- Comment #22 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177455&action=edit Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #23 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177456&action=edit Bug 26684: Remove marc column from existing databases Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #24 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177457&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #25 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177458&action=edit Bug 26684: Fix atomic update Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #26 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177459&action=edit Bug 26684: Remove marc from Koha::Authority::to_api_mapping Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #27 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177460&action=edit Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc Since we have misc/export_records.pl and we want to remove auth_header.marc, the ancient script misc/exportauth.pl can be removed as well (it is relied upon auth_header.marc). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #28 from David Nind <david@davidnind.com> --- Please add a test plan, and I'd be happy to test. (Replicate the issue (and what the issue is), apply patches, demonstrate that the issue is fixed.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #29 from David Nind <david@davidnind.com> --- Sorry, I thought this was waiting for sign off (has now been signed off). A test plan would be ideal for the QA step, and a release note would be great to explain what this fixes and why. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #30 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177461&action=edit Test data (one auth record) of size 92771 B -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #31 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to David Nind from comment #29)
A test plan would be ideal for the QA step, and a release note would be great to explain what this fixes and why.
It is hard to say about a strict test plan. One aspect of problems causing by this column can be illustrates by the following sequence of steps. 1. Take the provided test auth record (100 Baggins, Bilbo) with lots od 670 fields, of size 92771 B: still in the limits of ISO 2709, but significantly bigger than blob size (64 KB). 2. Try to import the record into ktd installation with: misc/migration_tools/bulkmarcimport.pl -a -d -file Baggins_Bilbo.mrc -fk You should see a series of warnings: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'marc' at row 1 at /kohadevbox/koha/Koha/Object.pm line 172 Use of uninitialized value $originalid in concatenation (.) or string at ./misc/migration_tools/bulkmarcimport.pl line 520, <GEN3> line 1. ERROR: Insert authority failed: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'marc' at row 1 at /kohadevbox/koha/Koha/Object.pm line 172 3. Control in ktd --dbshell with: select * from auth_header; You should see one row with no data in marc nor in marcxml. 4. Apply the patch ; updatedatabase. 5. Repeat p. 2 and p. 3. You should get no warnings and expected (huge) result from MySQL. Other aspects should be evaluated by code reviewers. The koha_header.marc column should not be used in the code anymore with this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #32 from David Nind <david@davidnind.com> --- Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177455|0 |1 is obsolete| | Attachment #177456|0 |1 is obsolete| | Attachment #177457|0 |1 is obsolete| | Attachment #177458|0 |1 is obsolete| | Attachment #177459|0 |1 is obsolete| | Attachment #177460|0 |1 is obsolete| | --- Comment #33 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177622&action=edit Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177623&action=edit Bug 26684: Remove marc column from existing databases Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177624&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177625&action=edit Bug 26684: Fix atomic update Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177626&action=edit Bug 26684: Remove marc from Koha::Authority::to_api_mapping Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177627&action=edit Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc Since we have misc/export_records.pl and we want to remove auth_header.marc, the ancient script misc/exportauth.pl can be removed as well (it is relied upon auth_header.marc). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30888 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | Severity|normal |enhancement QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree about removing the column, but I don't believe this is a bug fix. Setting to enhancement (moving back in queue a little). Also: setting Assignee and QA contact... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #40 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #39)
I agree about removing the column, but I don't believe this is a bug fix. Setting to enhancement (moving back in queue a little).
Also: setting Assignee and QA contact...
I wouldn't agree that it is just enhancement. IMO it is a real and quite serious bug. Please see comments # 19 and # 31. The limit of the size of blob makes auth_table and the whole authorities infrastructure fail in case of authority records of the size >= 64 KB (rare but real cases). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's still quite a big change, so I am not sure it should be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #42 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #41)
It's still quite a big change, so I am not sure it should be backported.
I get the point. I do not insist. It seems serious and it is but it shouldn't hurt anybody. On the contrary, it could save maybe not the life, but data ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 [Bug 30888] Add a table for deletedauthorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Passed QA |Patch doesn't apply --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc Using index info to reconstruct a base tree... M misc/exportauth.pl Falling back to patching base and 3-way merge... CONFLICT (modify/delete): misc/exportauth.pl deleted in Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc and modified in HEAD. Version HEAD of misc/exportauth.pl left in tree. error: Failed to merge in the changes. Please rebase. I need to rebase another one on top.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177622|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178277&action=edit Bug 26684: Remove marc from auth_header for new installs Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177623|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178278&action=edit Bug 26684: Remove marc column from existing databases Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177624|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178279&action=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177625|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178280&action=edit Bug 26684: Fix atomic update Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177626|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178281&action=edit Bug 26684: Remove marc from Koha::Authority::to_api_mapping Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177627|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178282&action=edit Bug 26684: Remove misc/exportauth.pl as a consequence of removing auth_header.marc Since we have misc/export_records.pl and we want to remove auth_header.marc, the ancient script misc/exportauth.pl can be removed as well (it is relied upon auth_header.marc). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Well, it was a trivial rebase after all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/AuthHeader.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. Please run misc/devel/update_dbix_class_files.pl to prevent that when generating the new schema file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178279|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178285&action=edit Bug 26684: {DBIx] Schema changes for AuthHeader.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can see these are really old patches still using the old atomicupdate template. I will port them, but if you see such things, please help and save some RM time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This change requires a change to our sample data used by ktd (reset_all) and Jenkins: auth_header.sql I've filed: https://gitlab.com/koha-community/koha-misc4dev/-/issues/86 We need an urgent fix please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sample data has been fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Before this patch we stored release notes| |both the MARC and the | |MARCXML record of an | |authority in the database | |table auth_header. With | |this patch the data is no | |longer duplicated and we | |are only storing the | |MARCXML record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #57 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org