[Bug 37989] New: Add template toolkit to problem_report notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Bug ID: 37989 Summary: Add template toolkit to problem_report notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Currently the PROBLEM_REPORT notice does not properly call the problemreports object into the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m Blocks| |36260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36260 [Bug 36260] Port default PROBLEM_REPORT notice to Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 171884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171884&action=edit Attachment to Bug 37989 - Add template toolkit to problem_report notice Bug 37989: Add template toolkit to problem_report notice This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- To test: 1. Turn on OPACReportProblem in the system preferences. 2. In the staff interface, create the following report: SELECT * FROM message_queue WHERE letter_id='PROBLEM_REPORT' 3. Log into the OPAC 4. Report a problem 5. Run the report you created. 6. Observe the data. (Bug 37991, the title doesn't store properly) 7. Apply the patch 8. Restart all services (restart_all on command line Restart Services in sandbox options) 9. Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username. 10. File a new OPAC problem report 11. Run your report. 2 usernames should now show. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #3 from Olivier Vezina <ovezina@inlibro.com> --- Created attachment 172019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172019&action=edit Bug 37989: Add template toolkit to problem_report notice This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Without the patch I get this: *************************** 2. row *************************** message_id: 2 letter_id: 90 borrowernumber: 51 subject: OPAC problem report content: Username: koha Problem page: / Title: this is the subject Message: this is the body metadata: letter_code: PROBLEM_REPORT message_transport_type: email status: pending time_queued: 2024-11-23 22:57:57 updated_on: 2024-11-23 22:57:57 to_address: root@localhost cc_address: NULL from_address: NULL reply_address: NULL content_type: NULL failure_code: ---------------------------- Isn't it okay? What is the expected anomaly? And it's the same with the patch. Even though in main there is not the problem_reports object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- @Lisette When attaching patches there should not be the "Attachment to" prefix to attachment name. It should be just the commit summary (1st line of the commit message). That's why we have twice the patch attached. Because they don't have exactly the same name so the 1st version isn't marked as obsolete and hidden. git bz does that by default but I think it's possible to get away without it and still get the same result. Also it look like "This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice" is not part of the commit summary so it should be spaced by an empty line in the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- Ah, both the confusion and the patch name came from doing this on my laptop during KohaCon between presentations. The test plan should have step 9 before the first one is created so you can see that the tt doesn't populate. Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username. Then you can see after the patch applies that it does. There's a bug this one blocks to update the default to use TT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175638&action=edit Bug 37989: Add template toolkit to problem_report notice This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice Test plan: 1. Turn on OPACReportProblem in the system preferences. 2. In the staff interface, create the following report: SELECT * FROM message_queue WHERE letter_id='PROBLEM_REPORT' 3. Log into the OPAC 4. Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username. 5. Report a problem 6. Run the report you created. 7. Observe the data. (Bug 37991, the title doesn't store properly) 8. Apply the patch 9. Restart all services (restart_all on command line Restart Services in sandbox options) 10. File a new OPAC problem report 11. Run your report. 2 usernames should now show. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Lisette Scheer from comment #6)
Ah, both the confusion and the patch name came from doing this on my laptop during KohaCon between presentations.
The test plan should have step 9 before the first one is created so you can see that the tt doesn't populate.
Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username.
Then you can see after the patch applies that it does.
There's a bug this one blocks to update the default to use TT.
Oops about that, it's a confusion from my side: It was about the commit summary (1st line of commit message) It's «Bug 37989: Add template toolkit to problem_report notice This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice» And it looks like it should be just «Bug 37989: Add template toolkit to problem_report notice» And the rest of the commit message be « This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice » About step 9 IIUC it should be above "Report a problem" With all that, tell me if the commit summary and the rest of the commit message is what you expect on the newly attached patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175638|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178472&action=edit Bug 37989: Add template toolkit to problem_report notice This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice Test plan: 1. Turn on OPACReportProblem in the system preferences. 2. In the staff interface, create the following report: SELECT * FROM message_queue WHERE letter_id='PROBLEM_REPORT' 3. Log into the OPAC 4. Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username. 5. Report a problem 6. Run the report you created. 7. Observe the data. (Bug 37991, the title doesn't store properly) 8. Apply the patch 9. Restart all services (restart_all on command line Restart Services in sandbox options) 10. File a new OPAC problem report 11. Run your report. 2 usernames should now show. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|victor@tuxayo.net |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add template toolkit to |Allow Template Toolkit for |problem_report notice |PROBLEM_REPORT notice Text to go in the| |This makes it possible to release notes| |use Template Toolkit syntax | |for the PROBLEM_REPORT | |notice linked to | |cataloguing concerns | |feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37989 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org