https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 137689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137689&action=edit Recalls history page The is the Recalls history page. Note that the logo and search bar are not visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 137729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137729&action=edit Bug 31153: Correct include for patron-search-header To test: 1) Turn on recalls 1.1) In Administration > Global system preferences, enable UseRecalls 1.2) Add recalls permissions in your circulation rules 2) In the OPAC, log in as a patron 3) Find a record with checked out items and place a recall 4) In the staff interface, go to the patron's account 5) Click on any tab on the left in the patron's account (e.g. Holds history) --> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs 6) Click on the 'Recalls history' tab --> Note that the Koha logo and search bar disappear 7) Apply patch 8) Conform search bar is there -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137729|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 137730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137730&action=edit Bug 31153: Correct include for patron-search-header To test: 1) Turn on recalls 1.1) In Administration > Global system preferences, enable UseRecalls 1.2) Add recalls permissions in your circulation rules 2) In the OPAC, log in as a patron 3) Find a record with checked out items and place a recall 4) In the staff interface, go to the patron's account 5) Click on any tab on the left in the patron's account (e.g. Holds history) --> Note that the Koha logo and search bar is at the top of the page between the module menu and the breadcrumbs 6) Click on the 'Recalls history' tab --> Note that the Koha logo and search bar disappear 7) Apply patch 8) Conform search bar is there Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Lucas! I still had my Recalls history page open from yesterday, so I only had to apply the patch and refresh the page :) It works perfectly! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 137731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137731&action=edit Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial code change, solid fix. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Recalls feature not present in 21.11. won't backport. -- You are receiving this mail because: You are watching all bug changes.