https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152519&action=edit Bug 34066: Datatable options don't fully translate on list of saved reports This patch corrects the DataTable option for defining an alternate language string when no records are returned by a table filter. An obsolete version of the option name was breaking the existing custom option supplied by our datatables.js To test, apply the patch and go to Reports -> Use saved.. - In the DataTable of existing reports, all the DataTable controls should look correct. - In the filter field at the top of the table, enter a string which will not be found. You should see a message, "No matching reports found." - Install another language if necessary, and switch to that language. - The labels on all the DataTable controls should show the terms which have been translated for that language. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152519|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 154322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154322&action=edit Bug 34066: Datatable options don't fully translate on list of saved reports This patch corrects the DataTable option for defining an alternate language string when no records are returned by a table filter. An obsolete version of the option name was breaking the existing custom option supplied by our datatables.js To test, apply the patch and go to Reports -> Use saved.. - In the DataTable of existing reports, all the DataTable controls should look correct. - In the filter field at the top of the table, enter a string which will not be found. You should see a message, "No matching reports found." - Install another language if necessary, and switch to that language. - The labels on all the DataTable controls should show the terms which have been translated for that language. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

- In the filter field at the top of the table, enter a string which will not be found. You should see a message, "No matching reports found."

Without the patch, I got "No matching reports found" translated in french with fr-FR enabled. But that shouldn't be the case, right? Isn't that's also what the patch is supposed to fix? (given the code change) Ok, it seems that "No matching reports found." works regardless. But the way it's implemented influences whether the pagination and search are translated. Very very weird. It seems that's how it's is 🤷 Works, makes sense functionally, QA script happy, code looks good, passing QA :) Gotcha when testing: if doing back and forth between with a without the patch, don't forget to redeploy the translation each time! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.