[Bug 34627] New: CMS pages do not correctly display the opaccredits footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Bug ID: 34627 Summary: CMS pages do not correctly display the opaccredits footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org To reproduce 1. Create an HTML customisation (in Staff interface -> tools -> HTML customisations) in the 'opaccredits' section. Give it some formatting i.e colours and headings 2. Save this and confirm it displays as expected on the OPAC 3. Create a custom page (in Staff interface -> tools -> pages) 4. Save this and open it in the OPAC 5. Notice the opaccredits section does not display as normal This is because the template for custom OPAC pages puts opaccredits inside the #main div, whereas other OPAC templates puts them outside the #main div -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154876&action=edit Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154876|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154878&action=edit Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154878|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 154892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154892&action=edit Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | Summary|CMS pages do not correctly |Fix CMS page HTML structure |display the opaccredits |so that footer content is |footer |displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks all! Can this please be backported for 23.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Feature added by Bug 15326 in 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org