[Bug 35124] New: Incorrect item groups table markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Bug ID: 35124 Summary: Incorrect item groups table markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 24857 On the detail page, under the items groups tab, the table headers don't display correctly (especially with Bug 34913 applied). This is because the header row contains <td>s instead of <th>s. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157558&action=edit Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157558|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 157581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157581&action=edit Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157581|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157593&action=edit Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35124 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org