[Bug 35000] New: Work in progress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Bug ID: 35000 Summary: Work in progress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Work in progress |OPACMandatoryHoldDates does | |not work well with | |flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156790&action=edit Bug 35000: Fix OPACMandatoryHoldDates feature in opac-reserve Somewhere (perhaps after bug 29012) this feature has been broken somehow. The fact that we have two inputs for the date and the active one is one level deeper, requires a few adjustments in the jquery selectors etc. (Note that two Required lines were visible too.) The corrected jquery constructs become a bit complexer now. Test plan: Enable AllowHoldDateInFuture + OPACAllowHoldDateInFuture. Set circ rule for book to test with allows item level holds. Set OPACMandatoryHoldDates to no hold dates. Place hold on a book in OPAC. Check that More options is collapsed. (If you force item level holds, it will open.) Set OPACMandatoryHoldDates to Hold start date. Refresh place hold page. More options is expanded now. Click Place hold. You should see an alert and focus goes to start date. Set OPACMandatoryHoldDates to Hold end date. Repeat place hold. Set OPACMandatoryHoldDates to Both hold dates. Fill one. Place hold. Bonus: Place hold on multiple biblios. Repeat former steps. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156790|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157213&action=edit Bug 35000: Fix OPACMandatoryHoldDates feature in opac-reserve Somewhere (perhaps after bug 29012) this feature has been broken somehow. The fact that we have two inputs for the date and the active one is one level deeper, requires a few adjustments in the jquery selectors etc. (Note that two Required lines were visible too.) The corrected jquery constructs become a bit complexer now. Test plan: Enable AllowHoldDateInFuture + OPACAllowHoldDateInFuture. Set circ rule for book to test with allows item level holds. Set OPACMandatoryHoldDates to no hold dates. Place hold on a book in OPAC. Check that More options is collapsed. (If you force item level holds, it will open.) Set OPACMandatoryHoldDates to Hold start date. Refresh place hold page. More options is expanded now. Click Place hold. You should see an alert and focus goes to start date. Set OPACMandatoryHoldDates to Hold end date. Repeat place hold. Set OPACMandatoryHoldDates to Both hold dates. Fill one. Place hold. Bonus: Place hold on multiple biblios. Repeat former steps. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thanks Katrin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157213|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157233&action=edit Bug 35000: Fix OPACMandatoryHoldDates feature in opac-reserve Somewhere (perhaps after bug 29012) this feature has been broken somehow. The fact that we have two inputs for the date and the active one is one level deeper, requires a few adjustments in the jquery selectors etc. (Note that two Required lines were visible too.) The corrected jquery constructs become a bit complexer now. Test plan: Enable AllowHoldDateInFuture + OPACAllowHoldDateInFuture. Set circ rule for book to test with allows item level holds. Set OPACMandatoryHoldDates to no hold dates. Place hold on a book in OPAC. Check that More options is collapsed. (If you force item level holds, it will open.) Set OPACMandatoryHoldDates to Hold start date. Refresh place hold page. More options is expanded now. Click Place hold. You should see an alert and focus goes to start date. Set OPACMandatoryHoldDates to Hold end date. Repeat place hold. Set OPACMandatoryHoldDates to Both hold dates. Fill one. Place hold. Bonus: Place hold on multiple biblios. Repeat former steps. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clear code, QA scripts happy and all working as expected. Thanks Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35000 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org