[Bug 35530] New: Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Bug ID: 35530 Summary: Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32721 It looks like they are for OPAC, but it's not visible in the library edit form. We should add a hint or rename the options with prefix OPAC. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Bug 35530 depends on bug 32721, which changed state. Bug 32721 Summary: Allow specifying UserCSS and UserJS at library level for the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't tell if UserCSS and |Can't tell if UserCSS and |UserJS in ibraries are for |UserJS in libraries are for |staff interface or OPAC |staff interface or OPAC CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 160626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160626&action=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160626|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160666&action=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I don't mind the replacement labels, as they are a great improvement: - UserJS -> Specific OPAC JS - UserCSS -> Specific OPAC CSS Some alternatives: 1. Library specific OPAC JavaScript Library specific OPAC CSS 2. Library specific JavaScript for the OPAC Library specific CSS for the OPAC 3. OPAC JavaScript for this library OPAC CSS for this library I think I like 3 better, but leaving up to the QA Team. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter.
I agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160666|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161423&action=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- --- Comment #9 from David Nind <david@davidnind.com> --- Changed status to "Needs documenting" - this changes the field label, which is described in the library administration section[1] and needs updating. [1] https://koha-community.org/manual/latest/en/html/administration.html#librari... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org