https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89254&action=edit Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings This patch moves untranslatable strings out of overdrive.js and into opac-bottom.inc where other strings are defined for use in JavaScript files. To test you must have OverDrive integration set up, including OverDriveCirculation. Test the various Overdrive integration features: - Placing holds - Cancelling holds - Checking out - Checking in These features should work as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89254|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 93224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93224&action=edit Tests were successful and worked as expected. Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings This patch moves untranslatable strings out of overdrive.js and into opac-bottom.inc where other strings are defined for use in JavaScript files. To test you must have OverDrive integration set up, including OverDriveCirculation. Test the various Overdrive integration features: - Placing holds - Cancelling holds - Checking out - Checking in These features should work as expected. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93224|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93234&action=edit Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings This patch moves untranslatable strings out of overdrive.js and into opac-bottom.inc where other strings are defined for use in JavaScript files. To test you must have OverDrive integration set up, including OverDriveCirculation. Test the various Overdrive integration features: - Placing holds - Cancelling holds - Checking out - Checking in These features should work as expected. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.