[Bug 23679] New: Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bug ID: 23679 Summary: Software error when trying to transfer an unknown barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 93164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93164&action=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 93165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93165&action=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93164|0 |1 is obsolete| | Attachment #93165|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93198&action=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93199&action=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93198|0 |1 is obsolete| | --- Comment #5 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93211&action=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93199|0 |1 is obsolete| | --- Comment #6 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93212&action=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93212|0 |1 is obsolete| | --- Comment #7 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93213&action=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93211|0 |1 is obsolete| | --- Comment #8 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93214&action=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93213|0 |1 is obsolete| | Attachment #93214|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93235&action=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93236&action=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- +my $badbc = 'wherethehelldoyoucomefrom'; Did you see this egg XD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org