[Bug 34300] New: Add link to place a hold on ordered items in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Bug ID: 34300 Summary: Add link to place a hold on ordered items in baskets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Libraries would like the ability to easily place a hold on an ordered item from the basket. We envision this button being available next to orders, by the other action buttons i.e. next to Modify/transfer and Cancel. It would be in its own column "Place hold" and should be configurable to show or hide using the Table settings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 153579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153579&action=edit Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153579|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153622&action=edit Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #3 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Worked as expected, I know lots of people will be excited to see this. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #4 from wainuiwitikapark@catalyst.net.nz --- (In reply to Lisette Scheer from comment #3)
Worked as expected, I know lots of people will be excited to see this. Lisette
Thanks Lisette! That's great to hear :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153622|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156367&action=edit Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA with a few minor comments: Place a hold on the order is a bit weird wording imho. Could be improved? No blocker. I wonder if Place hold should be hidden by default. If you want it, you will enable it? No blocker. The list of column settings (in Configure) is not ordered. This is outside scope here. But we might wanna think about that.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- This needs a check for permission 'CAN_user_reserveforothers_place_holds' right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156771&action=edit Bug 34300: (QA follow-up) Add permission check and fix missing table cells * Changes text from "Place a hold on order" to the more common "Place hold" * Adds permission check on reserveforothers. * We were missing table cells in the footer rows of the table. I would have liked to hide the column for someone missing permissions, but I failed to get the datatable configuration right with the export and column configuration settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can I get a review on the follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10498 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156771|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156983&action=edit Bug 34300: (QA follow-up) Add permission check and fix missing table cells * Changes text from "Place a hold on order" to the more common "Place hold" * Adds permission check on reserveforothers. * We were missing table cells in the footer rows of the table. I would have liked to hide the column for someone missing permissions, but I failed to get the datatable configuration right with the export and column configuration settings. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Passed QA |Pushed to master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/805 Documentation| |Philip Orr contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org