[Bug 33098] New: Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Bug ID: 33098 Summary: Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Currently when adding an order to a basket from an accepted suggestion, the status of the suggestion goes from 'accepted' to 'ordered'. If the order is then cancelled, the suggestion remains as 'ordered'. The status should be reverted to 'accepted' as it is no longer on order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 147526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147526&action=edit Bug 33098: Revert suggestion status when orders are cancelled This enhancement will revert the status of a suggestion from ORDERED to ACCEPTED when an order made from a suggestion is cancelled. To test: 1. Log into the OPAC and go to purchase suggestions 2. Add a new purchase suggestion 3. Log into the staff interface. The suggestion will show on the home page 4. Select the suggestion and mark it as Accepted 5. Go to Acquisitions. Find or create a basket 6. Add an order to the basket from a suggestion 7. You'll be redirected to the suggestions page. Click the order button next to your suggestion 8. Fill out the order details as normal and confirm the order. 9. In a new tab, go to the suggestions management page and confirm the suggestion now shows as ORDERED. 10. In the other tab with your basket, cancel the order you just made from the suggestion. 11. Refresh the suggestions management tab. Confirm the suggestion now shows as ACCEPTED. 12. Confirm tests pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- When testing, I still see the canceled orders as "ordered" on both the Staff Intranet and Opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks Laura, if a test plan fails please set the Status to "failed QA". I'll take another look at this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I've just re-tested this and the test plan still works - perhaps you forgot to restart services after applying the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #4)
I've just re-tested this and the test plan still works - perhaps you forgot to restart services after applying the patch?
Aleisha, I indeed forgot to restart the services after applying the patch. I retested everything and it works as expected. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147526|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 149826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149826&action=edit Bug 33098: Revert suggestion status when orders are cancelled This enhancement will revert the status of a suggestion from ORDERED to ACCEPTED when an order made from a suggestion is cancelled. To test: 1. Log into the OPAC and go to purchase suggestions 2. Add a new purchase suggestion 3. Log into the staff interface. The suggestion will show on the home page 4. Select the suggestion and mark it as Accepted 5. Go to Acquisitions. Find or create a basket 6. Add an order to the basket from a suggestion 7. You'll be redirected to the suggestions page. Click the order button next to your suggestion 8. Fill out the order details as normal and confirm the order. 9. In a new tab, go to the suggestions management page and confirm the suggestion now shows as ORDERED. 10. In the other tab with your basket, cancel the order you just made from the suggestion. 11. Refresh the suggestions management tab. Confirm the suggestion now shows as ACCEPTED. 12. Confirm tests pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Waikato Institute of Technology Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- @Laura hi, thanks for the signoff :) The "Signed-off-by" line needs to be added to the patch itself and the updated/signed patch needs to be attached to the ticket here. You likely have git bz installed in you test environment or maybe you are using the sandboxes. Here is some documentation about how add a signoff to a patch and how to attach it here. You might want to discuss that with a colleague to find what's the most efficient or simplest workflow for your case. https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_1:_Using_san... https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_2%3A_Using_g... https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement will release notes| |revert the status of a | |suggestion from `ORDERED` | |to `ACCEPTED` when an order | |made from a suggestion is | |cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29027 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.breton@ccsr.qc.ca --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18770 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Documentation| |Philip Orr contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/776 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org