[Bug 17209] New: Remove use of onclick from masthead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Bug ID: 17209 Summary: Remove use of onclick from masthead Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54966&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54966|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54974&action=edit [SIGNED-OFF] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 54974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54974 [SIGNED-OFF] Bug 17209: Remove use of onclick from masthead Review of attachment 54974: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17209&attachment=54974) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +237,4 @@
} });
+ $(".persona").on("click",function(){
Why don't you use the existing id node (logout) to catch it instead of adding a new class? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54974|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 55592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55592&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Marc Véron <veron@veron.ch> --- Sorry, I get a merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55592|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 57875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57875&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Merge conflict fixed, ready to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57875|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 58238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58238&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58238|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58455&action=edit Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org