https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677 [Bug 17677] Move C4::Circulation code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57770&action=edit Bug 17679: C4::Circulation - Remove unused GetItemIssues Ready for an archaeology course? C4::Circulation::GetItemIssues is only used once, from catalogue/issuehistory.pl This call has been added by commit 95d6452462a560ba0c0ac859a2cfb7783c25c925 Adding some more information on issuehistory. which says "Adding itemnumber to issuehistory.pl API so that one could search for issuehistory of a specific item." So it added the ability to see the item issue history but did not provide a way to access it via the interface. It's ok so far but this subroutine is broken since commit aa114f53499b9cffde0571fe7e08622f9c9a332a Bug 5549 : Only use DateTime for issues table because of this change: - my $today = C4::Dates->today('iso'); + my $today = DateTime->now( time_zome => C4::Context->tz); I let you catch the typo ;) And since this commit the subroutine explodes with "The following parameter was passed in the call to DateTime::from_epoch but was not listed in the validation options: time_zome" Since it has never been raised by someone and that the feature is hidden, I'd recommend to simply remove it. Note that the "Checked out from" column would have been wrong even if we fixed all the previous issue. Test plan: Just dig into the code and confirm what this commit message tells -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- I totally agree with removing this part of code. Just few comments: qa tool is saying this: FAIL catalogue/issuehistory.pl FAIL valid "my" variable $biblio masks earlier declaration in same scope also in the copied part of issuhistory.pl, line 53: my $total = scalar @$issues; but $total is not used and the number of issues is passed to template by this lines: $template->param( total => scalar @$issues, ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57770|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57783&action=edit Bug 17679: C4::Circulation - Remove unused GetItemIssues Ready for an archaeology course? C4::Circulation::GetItemIssues is only used once, from catalogue/issuehistory.pl This call has been added by commit 95d6452462a560ba0c0ac859a2cfb7783c25c925 Adding some more information on issuehistory. which says "Adding itemnumber to issuehistory.pl API so that one could search for issuehistory of a specific item." So it added the ability to see the item issue history but did not provide a way to access it via the interface. It's ok so far but this subroutine is broken since commit aa114f53499b9cffde0571fe7e08622f9c9a332a Bug 5549 : Only use DateTime for issues table because of this change: - my $today = C4::Dates->today('iso'); + my $today = DateTime->now( time_zome => C4::Context->tz); I let you catch the typo ;) And since this commit the subroutine explodes with "The following parameter was passed in the call to DateTime::from_epoch but was not listed in the validation options: time_zome" Since it has never been raised by someone and that the feature is hidden, I'd recommend to simply remove it. Note that the "Checked out from" column would have been wrong even if we fixed all the previous issue. Test plan: Just dig into the code and confirm what this commit message tells -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57783|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57784&action=edit [SIGNED-OFF] Bug 17679: C4::Circulation - Remove unused GetItemIssues Ready for an archaeology course? C4::Circulation::GetItemIssues is only used once, from catalogue/issuehistory.pl This call has been added by commit 95d6452462a560ba0c0ac859a2cfb7783c25c925 Adding some more information on issuehistory. which says "Adding itemnumber to issuehistory.pl API so that one could search for issuehistory of a specific item." So it added the ability to see the item issue history but did not provide a way to access it via the interface. It's ok so far but this subroutine is broken since commit aa114f53499b9cffde0571fe7e08622f9c9a332a Bug 5549 : Only use DateTime for issues table because of this change: - my $today = C4::Dates->today('iso'); + my $today = DateTime->now( time_zome => C4::Context->tz); I let you catch the typo ;) And since this commit the subroutine explodes with "The following parameter was passed in the call to DateTime::from_epoch but was not listed in the validation options: time_zome" Since it has never been raised by someone and that the feature is hidden, I'd recommend to simply remove it. Note that the "Checked out from" column would have been wrong even if we fixed all the previous issue. Test plan: Just dig into the code and confirm what this commit message tells Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Looks fine for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.