[Bug 24337] New: Checkout note cannot be marked seen if more than 20 exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Bug ID: 24337 Summary: Checkout note cannot be marked seen if more than 20 exist Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When there are more than 20 checkout notes in the system, Koha fails to attach actions to the Seen/Not Seen buttons for checkout notes that are not on the first page of notes at cgi-bin/koha/circ/checkout-notes.pl. To Test: - create 21 checkout notes - go to cgi-bin/koha/circ/checkout-notes.pl - inspect the Seen/Not Seen buttons on the 21st note, see that there is no event attached I also filed bug 24335 while looking at this. I don't think it's related, but mentioning it just in case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think the patch for Bug 24335 fixes this. However, there remains the ambiguity about whether or not those batch operations will affect checked items which are not on the current "page" of the table. For instance: - I check all items on the first page - I navigate to the next page - I check all the items on the second page - I click the "Mark seen" button Result: Only the checked items on the second page are marked seen. One possible solution: A prompt asking the user whether they want to finish what they're doing before switching pages in the table. I bring this up in case this bug should be repurposed to address that issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I tried this while signing off on 24335. The Seen/Not Seen buttons on the second page still didn't work for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24335 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 [Bug 24335] Cannot mark checkout notes seen/not seen in bulk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96801&action=edit Bug 24337: Checkout note cannot be marked seen if more than 20 exist This patch modifies the event handler on the individual "Mark seen" / "Mark unseen" buttons in the table of checkout notes. For an event to be successfully attached to a hidden element it must be given a context. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Navigate to the second "page" of data in the DataTable. - Test the functionality of the "Mark seen" and "Mark unseen" buttons. They should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrew Fuerste-Henry from comment #2)
The Seen/Not Seen buttons on the second page still didn't work for me.
Thanks Andrew, I misunderstood. Hopefully this patch works for you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96801|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96802&action=edit Bug 24337: Checkout note cannot be marked seen if more than 20 exist This patch modifies the event handler on the individual "Mark seen" / "Mark unseen" buttons in the table of checkout notes. For an event to be successfully attached to a hidden element it must be given a context. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Navigate to the second "page" of data in the DataTable. - Test the functionality of the "Mark seen" and "Mark unseen" buttons. They should work correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In retrospect, I didn't describe it well. Signing off. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96802|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97173&action=edit Bug 24337: Checkout note cannot be marked seen if more than 20 exist This patch modifies the event handler on the individual "Mark seen" / "Mark unseen" buttons in the table of checkout notes. For an event to be successfully attached to a hidden element it must be given a context. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Navigate to the second "page" of data in the DataTable. - Test the functionality of the "Mark seen" and "Mark unseen" buttons. They should work correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org