[Bug 24335] New: Cannot mark checkout notes seen/not seen in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Bug ID: 24335 Summary: Cannot mark checkout notes seen/not seen in bulk Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On checkout-notes.pl the Mark Seen and Mark Not Seen buttons at the top of the page remain greyed out when one selects notes from the list. To test: - turn on AllowCheckoutNotes - generate a checkout and a checkout note - go to /cgi-bin/koha/circ/checkout-notes.pl - click the checkbox for your note - verify that the Mark Seen button at the top of the screen remains grey and inoperable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96799&action=edit Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96799|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96800&action=edit Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Patch worked for me, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 [Bug 24337] Checkout note cannot be marked seen if more than 20 exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96800|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97172&action=edit Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org