[Bug 35961] New: Modal include missing for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Bug ID: 35961 Summary: Modal include missing for catalog concerns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 31028 Jonathan Druart 2024-01-29 10:23:15 GMT The modal only opens on opac-detail, however "Report a concern" is displayed on other pages (opac-isbd, opac-marc, etc.) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166637&action=edit Bug 35961: Add missing includes This patch adds the missing includes for the 'Catalog concerns' modal on opac-MARCdetail and opac-ISBDdetail views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This doesn't work for me on the opac-MARC or opac-ISBD pages. When I hit submit on those pages I get "There was an error when submitting your concern, please contact a librarian." If I review the source I see this: <input type="hidden" name="reporter_id" id="concern_reporter" value=""> If I give that input a value of '51' I can successfully submit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166658&action=edit Bug 35961:i (follow-up) Pass along the borrowernumber To test: 1. APPLY PATCH 2. Turn on OpacCatalogConcerns 3. Find a record and go to the OPAC detail page. 4. Click "Report a concern" in the right navigation menu 5. Make sure it works 6. Repeat the proces from MARC view and ISBD view pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166637|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 166663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166663&action=edit Bug 35961: Add missing includes This patch adds the missing includes for the 'Catalog concerns' modal on opac-MARCdetail and opac-ISBDdetail views. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 166664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166664&action=edit Bug 35961: (follow-up) Pass along the borrowernumber To test: 1. APPLY PATCH 2. Turn on OpacCatalogConcerns 3. Find a record and go to the OPAC detail page. 4. Click "Report a concern" in the right navigation menu 5. Make sure it works 6. Repeat the proces from MARC view and ISBD view pages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Works as expected. I did have some odd behavour when logged out and then logging in to submit the concern. I was getting an error "There was an error when submitting your concern, please contact a librarian." when submitting on the ISBD view or MARC view, but not consistently. Browser console error is: "Failed to load resource: the server responded with a status of 400 (Bad Request) :8080/api/v1/public/tickets:1" However, I think this is related to not having hostnames configured correctly for my desktop and KTD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166663|0 |1 is obsolete| | Attachment #166664|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166774&action=edit Bug 35961: Add missing includes This patch adds the missing includes for the 'Catalog concerns' modal on opac-MARCdetail and opac-ISBDdetail views. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166775&action=edit Bug 35961: (follow-up) Pass along the borrowernumber To test: 1. APPLY PATCH 2. Turn on OpacCatalogConcerns 3. Find a record and go to the OPAC detail page. 4. Click "Report a concern" in the right navigation menu 5. Make sure it works 6. Repeat the proces from MARC view and ISBD view pages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org