[Bug 36845] New: Do not translate noindex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Bug ID: 36845 Summary: Do not translate noindex Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com While translating, I found the string "noindex". I think this should not be translated, as robots will probably no understand the command otherwise. The string was found in these pages - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt:8 - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt:9 - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:28 I added a general comment in weblate, but it should probably not be picked up by the translating tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166674&action=edit Bug 36845: Exclude meta tag from the translations This bug originaly wants to get rid of "noindex" coming from this meta tag: <meta name="robots" content="noindex"> But actually we have other strings from the meta tags that should not be translated. Test plan: 0. Do not apply this patch 1. cd misc/translator/po && gulp po:update --lang es-ES (or any other lang) 2. git commit -a -m"wip" 3. Apply this patch 4. Repeat 1 and git diff to show the diff Notice that strings that should not be translated are removed from the po files (actually commented) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166674|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 166737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166737&action=edit Bug 36845: Exclude meta tag from the translations This bug originaly wants to get rid of "noindex" coming from this meta tag: <meta name="robots" content="noindex"> But actually we have other strings from the meta tags that should not be translated. Test plan: 0. Do not apply this patch 1. cd misc/translator/po && gulp po:update --lang es-ES (or any other lang) 2. git commit -a -m"wip" 3. Apply this patch 4. Repeat 1 and git diff to show the diff Notice that strings that should not be translated are removed from the po files (actually commented) Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thank you Jonathan! I was very confused by the additions in the diff until I saw "(actually commented)" in step 4. Phew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not translate noindex |Exclude meta tag from the | |translations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- for my $a ('alt', 'content', 'title', 'value', 'label', 'placeholder', 'aria-label') { if ($attr->{$a}) { next if $a eq 'label' && $tag ne 'optgroup'; next if $a eq 'content'; Why do we loop over content? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #4)
Why do we loop over content?
I wondered the same thing. I don't see any instances of a content attribute being used for something which needs to be translated. MDN says <meta> is the only element the attribute can be used with. Theoretically the 'meta description' might have translatable content but we have that populated by a system preference so the content can't be translated anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166936&action=edit Bug 36845: Do not loop over the content attribute We skip it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166737|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166980&action=edit Bug 36845: Exclude meta tag from the translations This bug originaly wants to get rid of "noindex" coming from this meta tag: <meta name="robots" content="noindex"> But actually we have other strings from the meta tags that should not be translated. Test plan: 0. Do not apply this patch 1. cd misc/translator/po && gulp po:update --lang es-ES (or any other lang) 2. git commit -a -m"wip" 3. Apply this patch 4. Repeat 1 and git diff to show the diff Notice that strings that should not be translated are removed from the po files (actually commented) Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166936|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166981&action=edit Bug 36845: Do not loop over the content attribute We skip it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a string change so to speak, but I think removing strings doesn't really count. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36845 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org