[Bug 38685] New: ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Bug ID: 38685 Summary: ILL pages have incomplete breadcrumbs Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175397&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175399&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175400&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175401&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175397|0 |1 is obsolete| | Attachment #175399|0 |1 is obsolete| | Attachment #175400|0 |1 is obsolete| | Attachment #175401|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175460&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175461&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175462&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175463&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175460|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176273&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175461|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176274&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175462|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176275&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175463|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176276&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 [Bug 38441] ILL - Allow for a history check workflow stage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176273|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179787&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176274|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179788&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176275|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179789&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176276|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179790&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased and tidied on top of tidied bug 35604 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179787|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180874&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179788|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180875&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179789|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180876&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179790|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180877&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35604 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |aude.charillon@openfifth.co | |.uk --- Comment #24 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for a mention in the Manual (main functionality will be documented as part of bug 35604). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org