[Bug 38761] New: Backend plugins that are disabled remain visible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Bug ID: 38761 Summary: Backend plugins that are disabled remain visible Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 19605 Blocks: 35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175824&action=edit Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175825&action=edit Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175824|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175826&action=edit Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175825|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175827&action=edit Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #5 from David Nind <david@davidnind.com> --- Tests after both patches applied: - if no ILL backend plugins installed and enabled, the tests fail - if an ILL backend is installed, the tests pass Before the patches were applied (with no ILL backend plugins installed), the tests passed. prove t/db_dependent/Koha/ILL/Request/Config.t t/db_dependent/Koha/ILL/Request/Config.t .. 1/9 # Failed test 'get_backend_plugin_names returns list of backend plugin names' # at t/db_dependent/Koha/ILL/Request/Config.t line 530. # got: undef # expected: 'Test Plugin' # Looks like you failed 1 test of 3. # Failed test 'get_backend_plugin_names() tests' # at t/db_dependent/Koha/ILL/Request/Config.t line 545. # Looks like you failed 1 test of 9. t/db_dependent/Koha/ILL/Request/Config.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/Koha/ILL/Request/Config.t (Wstat: 256 (exited 1) Tests: 9 Failed: 1) Failed test: 9 Non-zero exit status: 1 Files=1, Tests=9, 1 wallclock secs ( 0.01 usr 0.01 sys + 1.01 cusr 0.17 csys = 1.20 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35604 | Status|Failed QA |Needs Signoff Depends on| |35604 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi David, thank you. I had the dependencies wrong. Bug 35604 adds the required 'ill_backend' method to Koha/Plugin/Test.pm. Tests should pass now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175826|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 175931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175931&action=edit Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175827|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 175932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175932&action=edit Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175931|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176271&action=edit Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175932|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176272&action=edit Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Test driven development, QA scripts happy, No regressions, bug fixed. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bugfix depends on a bigger feature patch. Any chance we could untangle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #12)
This bugfix depends on a bigger feature patch. Any chance we could untangle?
I think we can untangle, if we must, but the feature blocking this has sat as SO for 8 months and only recently PQA because we (PTFS-E) have QAd it ourselves. It's its own standalone feature and should not have any impact on current functionality for those upgrading that choose not to use it. Furthermore, we (PTFS-E) have proven time and time again that we are quick to react and fix any eventual issues introduced by our patches (and often times introduced by patches from others). I suppose what I am saying is, we can untangle, but at the same time, can bug 35604 be considered to be reviewed by RM? For push or, ultimately if that's the case, FQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was working through the bug fixes with the stable releases in mind. Of course the other bug will be reviewed, I was only wondering if we could get this one into stable releases independently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176271|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179936&action=edit Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176272|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179937&action=edit Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed a merge conflict in the tests to make them apply on top of bug 35604. Easy to test :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35604 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #20 from David Nind <david@davidnind.com> --- Bug fix, no change to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org