[Bug 40950] New: Don't forbid 'falsy' in codespell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Bug ID: 40950 Summary: Don't forbid 'falsy' in codespell Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org As a programmer, I like the 'falsy' idiom. It is totally relevant for Perl as we don't have booleans but 'falsy' values (empty string, empty array, undefined, etc). I propose to add a codespell exception to allow it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 187408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187408&action=edit Bug 40950: Add 'falsy' programming idiom to codespell dictionary The term 'falsy' is a standard JavaScript idiom referring to values that evaluate to false in boolean contexts (false, 0, '', null, undefined, NaN). This is widely used in modern JavaScript and is part of the official ECMAScript specification terminology. I also believe it is relevant for Perl. Codespell currently flags 'falsy' as a misspelling, but this is incorrect as it's legitimate technical terminology used throughout our JavaScript codebase and documentation. Changes: - Add 'falsy' to codespell exceptions/dictionary - Allows proper use of JavaScript terminology in code and comments Test plan: 1. Apply patch 2. Run codespell on files containing 'falsy' => SUCCESS: No longer flagged as misspelling 3. Verify 'falsy' usage in JavaScript context works correctly 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187408|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187436&action=edit Bug 40950: Add 'falsy' programming idiom to codespell dictionary The term 'falsy' is a standard JavaScript idiom referring to values that evaluate to false in boolean contexts (false, 0, '', null, undefined, NaN). This is widely used in modern JavaScript and is part of the official ECMAScript specification terminology. I also believe it is relevant for Perl. Codespell currently flags 'falsy' as a misspelling, but this is incorrect as it's legitimate technical terminology used throughout our JavaScript codebase and documentation. Changes: - Add 'falsy' to codespell exceptions/dictionary - Allows proper use of JavaScript terminology in code and comments Test plan: 1. Apply patch 2. Run codespell on files containing 'falsy' => SUCCESS: No longer flagged as misspelling 3. Verify 'falsy' usage in JavaScript context works correctly 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|enhancement |minor CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is a minor bug fix that and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40950 Bug 40950 depends on bug 38201, which changed state. Bug 38201 Summary: VueJS architecture rethink https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org