[Bug 14687] New: Patron's transaction history changes items' order after paying fines.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Bug ID: 14687 Summary: Patron's transaction history changes items' order after paying fines. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: j.kylmala@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com 1. Go to: Staff side -> Patrons -> X patron -> Fines -> *Create manual invoice* 2. Create one invoice with amount of 1. 3. Create other invoice with amount of 2. 4. Go to tab *Account* and take a look how the transactions are ordered. 5. Go to tab *Pay fines* and click Pay amount and then confirm. 6. Now you can see that in the *Account* tab the order of transactions have changed and that they go in the wrong order now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41553&action=edit Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Joonas Kylmälä <j.kylmala@gmail.com> --- Test plan for the patch above: 1. Go to: Staff side -> Patrons -> X patron -> Fines -> *Create manual invoice* 2. Create one invoice with amount of 1. 3. Create other invoice with amount of 2. 4. Go to tab *Account* and take a look how the transactions are ordered. 5. Go to tab *Pay fines* and click Pay amount and then confirm. 6. Now you can see that in the *Account* tab the order of transactions have changed and that they go in the wrong order now. 7. Apply patch and see that the transactions are now ordered from newest to oldest. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |j.kylmala@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41553|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 44532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44532&action=edit Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44532|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44552&action=edit [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron's transaction |Patron's transaction |history changes items' |history changes items' |order after paying fines. |order after paying fines CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org